1520888 - Spocs ready state

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Scott [:thecount] Downe]

Technically this is a everything ready state.

Needs to be set to true when layout, feeds, and potential spocs are fetched and ready to render. The reason why it's a spocs ready state is because spocs is the last to be fetched. It needs to fire if spocs are set or not.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4701

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/148eae0956a66dd23af4322408d4343046189ae6
Bug 1520888 - Ensure spocs don't load over a rec. (#4701)

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/9fb96d1b0b37

Comment 4

[Scott [:thecount] Downe]

To test:

If you're still seeing spocs with this pref: {"enabled":true,"show_spocs":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all"}

You might need to scroll down a bit, but they should be in there as per usual.

Comment 5

[Brahmini Nagabandi]

How do I identify spoc?

Comment 6

[Brahmini Nagabandi]

Got to be Sponsored by...

Comment 7

[Brahmini Nagabandi]

Attachment: QA Result : bug - 1520888.png

QA Results:

Tested on :

FF Nightly version : 66.0a1 (2019-01-25)
OS : Mac and Windows 10 Pro

Results Attached : QA Result : bug - 1520888.png

Closing as verified.