1520889 - Need to be able to turn spocs on and off via a pref and possibly an opt out

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Scott [:thecount] Downe]

This is basically to align with the release functionality.

I dunno how much of a priority it is.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4718

Comment 2

[Scott [:thecount] Downe]

To test:

1. Set pref browser.newtabpage.activity-stream.discoverystream.config to {"enabled":true,"show_spocs":false,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=control"}
2. Ensure third card in a new tab is not a spoc.
3. Set pref browser.newtabpage.activity-stream.discoverystream.config to {"enabled":true,"show_spocs":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=control"} and browser.newtabpage.activity-stream.showSponsored to true
4. Ensure third card in a new tab is a spoc (should have a blue "sponsored by ..." label now).

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/46828d5f339e24cf31e25d009d51c0b41a8fc142
Bug 1520889 - Pref for toggling spocs on and off. (#4718)

* Bug 1520889 - Pref for toggling spocs on and off.

* review

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/9d660bf33923