1520895 - [Ronin Windows] define windows exe package install class (win_exe_pkg)

Status: RESOLVED WONTFIX

(Infrastructure & Operations :: RelOps: Puppet, task)

Comment 1

[Mark Cornmesser [:markco]]

For some the reason Puppet's Windows package provider does not pass installation arguments. This is to work around it. It will pass both the path to the exe and the arguments as 2 strings to an exec class. For not it creates and flag file after installation, so that the package isn't installed on every run.

This works for now but in the future (and before this bug is closed) a programmatic check of the installation and a version check should be added.

Currently this is here:
https://github.com/markcor/ronin-win-base/blob/master/site/shared/manifests/pkg/win_exe_pkg.pp

This Source Code Form is subject to the terms of the Mozilla Public

License, v. 2.0. If a copy of the MPL was not distributed with this

file, You can obtain one at http://mozilla.org/MPL/2.0/.

define shared::pkg::win_exe_pkg ( $pkg, $package=$title, $install_options_string=[]) {

include shared::dirs::win_ronin_dirs

$pkgdir = lookup('loc_pkg_dir')
$srcloc = lookup('ext_pkg_src')
$semaphoredir = $facts['roninsemaphoredir']

file { "$pkgdir\\$pkg" :
	source => "$srcloc/$pkg",
}
exec { "$title install":
	require => File["$semaphoredir"],
	command => "$pkgdir\\$pkg $install_options_string",
	creates => "$semaphoredir\\$pkg",
	notify   => File["$semaphoredir\\$pkg"],
}
file { "$semaphoredir\\$pkg.semaphore":
	ensure => present,
}

}

Bug list

https://bugzilla.mozilla.org/show_bug.cgi?id=1520895

TODO

Add a programatic check to verify the package is installed

Add the ability to check the version

Comment 2

[Mark Cornmesser [:markco]]

Will reopen in Jira as needed.