1520898 - spocs info displayed in card

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Scott [:thecount] Downe]

When a card is a spoc, we need to be like release and mention that somewhere.

Spocs return a line of text explaining who sponsored the card, we just need to display it in the card.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4696

Comment 2

[Scott [:thecount] Downe]

Testing instructions.

1. Ensure the new tab is the regular version by default.
2. In about:config, change browser.newtabpage.activity-stream.discoverystream.config to be {"enabled":true,"layout_endpoint":"https://gist.githubusercontent.com/ScottDowne/e8ad372bc57ed3feba0bf02f89473fc9/raw/74daf564fea3e41e1ef24c39b18690623679182b/mrspocs"}
3. Ensure new tab is rendering a bunch of spocs with the text "Sponsored by..." in a few. Specifically, it's in the last two on the card grid, and the first and last on the hero.
4. Reset the pref, ensure everything is back to normal.

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/ed534b142246a543faa16c325cabcfe512825d64
Bug 1520898 - Display spoc context. (#4696)

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/5f9e44c1bbd5

Comment 5

[Brahmini Nagabandi]

Attachment: QA Result : bug - 1520898.png

QA Results:

Tested on :

FF Nightly version : 66.0a1 (2019-01-25)
OS : Mac and Windows 10 Pro

Results attached QA Result : bug - 1520898.png

Works as expected. Looks good to me.

Closing as verified.