Find new solution for "Quick find shortcut both opens the findbar and types a slash in the inputbox "

RESOLVED FIXED in Thunderbird 66.0

Status

defect
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: mkmelin, Assigned: florian)

Tracking

({regression})

Trunk
Thunderbird 66.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

As found while doing bug 1519091, disablefastfind no longer exists since bug 1486984.

A new solution should be implemented for "Quick find shortcut both opens the findbar and types a slash in the inputbox". Bug 1161930 originally implemented it.

Posted patch FixSplinter Review
Assignee: nobody → florian
Status: NEW → ASSIGNED
Comment on attachment 9037404 [details] [diff] [review]
Fix

This is based on the initial fix proposed in bug 1161930 (attachment 8606247 [details] [diff] [review]) before we had found a way to make disablefastfind work.
Attachment #9037404 - Attachment description: prevent opening the find bar when typing a slash while a chat conversation is focused, → Fix
Attachment #9037404 - Flags: review?(nhnt11)
Comment on attachment 9037404 [details] [diff] [review]
Fix

Review of attachment 9037404 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't test the patch but it looks good.
Attachment #9037404 - Flags: review?(nhnt11) → review+
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/4f66ed336bcf
prevent opening the find bar when typing a slash while a chat conversation is focused. r=nhnt11

Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 66.0
You need to log in before you can comment on or make changes to this bug.