1520933 - Implement filter styles in the new rules view

Status: NEW

(DevTools :: Inspector: Rules, enhancement, P3)

Description

[Tim Nguyen :ntim]

It was originally requested to avoid code duplication between the rules view and the computed view, see bug 1154789, so I don't see any reason not to use the shared SearchBox component in the rules view. It implements the highlight behaviour and the clear button hiding behaviour for free.

https://searchfox.org/mozilla-central/source/devtools/client/shared/components/SearchBox.js

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Yes, we should use the SearchBox component when we do implement the filtering of styles in the rules view. I did attempt to use SearchBox component in my original patch, but ended up reverting when I couldn't figure which props were required to get the SearchBox to show up, but also not have any functionality.

Comment 2

[Sebastian Zartner [:sebo]]

The current filter field allows to do an exact search by using backticks. Can this functionality be kept with the shared SearchBox component? And if so, should UI improvements for this be covered by this issue or should I create a separate one? Because I'd like to suggest creating a visible UI like a button or checkbox for the exact filtering to improve the discoverability of this feature.

Sebastian

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

(In reply to Sebastian Zartner [:sebo] from comment #2)

The current filter field allows to do an exact search by using backticks. Can this functionality be kept with the shared SearchBox component? And if so, should UI improvements for this be covered by this issue or should I create a separate one? Because I'd like to suggest creating a visible UI like a button or checkbox for the exact filtering to improve the discoverability of this feature.

Sebastian

That's a good question. I would've implemented the same behavior that we currently have, but I am working on Fenix these days. So, I will unassign myself from this bug.

Comment 4

[Sebastian Zartner [:sebo]]

Thank you for the quick response, Gabriel! So I'll redirect the question to Tim.

Sebastian

Comment 5

[Tim Nguyen :ntim]

(In reply to Sebastian Zartner [:sebo] from comment #2)

The current filter field allows to do an exact search by using backticks. Can this functionality be kept with the shared SearchBox component?

The shared SearchBox component supports an onChange property, so it should be possible.

And if so, should UI improvements for this be covered by this issue or should I create a separate one? Because I'd like to suggest creating a visible UI like a button or checkbox for the exact filtering to improve the discoverability of this feature.

A separate one would be better, since I don't think anyone is working on the rules view rewrite nowadays.