Remove support for notification bars in Password Manager (not used in Fx)
Categories
(Toolkit :: Password Manager, enhancement, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: MattN, Assigned: prathiksha)
Details
Attachments
(1 file, 2 obsolete files)
nsLoginManagerPrompter.js supports 3 different styles of prompts: doorhangers, dialogs, and notification bars. The notification bars aren't used or tested by Firefox and they make the doorhanger code more complicated. The code also became quite messy and fragile with the move to e10s since it still tries to support non-e10s consumers. Removing support for notification bars will make other refactorings and doorhanger maintenance easier.
jorgk, do you know if this will affect Thunderbird? I don't know if the password manager notification bars ever appear during regular use of TB. I guess they may appear if a legacy add-on loads a webpage with login fields but even then we may already fallback straight to a dialog?
|
||
Comment 1•5 years ago
|
||
Thanks for the heads-up. (Un)fortunately I don't know everything ;-) - Magnus, Geoff?
|
||
Comment 2•5 years ago
|
||
I don't think I ever saw a password notification bar in Thunderbird. AFAIK, we only use dialogs.
|
Assignee | |
Updated•5 years ago
|
|
Reporter | |
Comment 4•5 years ago
|
||
Thanks for the confirmations! We'll go ahead and remove the old password notification bars.
|
|
Assignee | |
Comment 5•5 years ago
|
||
Pushed by prathikshaprasadsuman@gmail.com: https://hg.mozilla.org/integration/autoland/rev/0d52389e664d Remove support for notification bars in Password Manager. r=MattN
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 8•5 years ago
|
||
Bug 1174327 - Add an Allow/Disallow autofill password option. r?MattN
|
|
Assignee | |
Comment 9•5 years ago
|
||
Bug 1174327 - Add an Allow/Disallow autofill password option. r?MattN
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
Description
•