Closed Bug 1520989 Opened 11 months ago Closed 11 months ago

Represent the Option<Percentage> from LengthPercentage as something Gecko can understand.

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: emilio, Assigned: emilio)

Details

Attachments

(1 file)

Not the prettiest, but it will work, and LengthPercentage will be 12 bytes which is pretty good (we could do better if wanted I guess):

  • Au(i32) length;
  • f32 percentage;
  • AllowedNumericType(u8) clamping_mode;
  • bool has_percentage;
  • bool was_calc;

This will allow me to start moving C++ stuff to use this representation.

Not the prettiest, but it will work, and LengthPercentage will be 12 bytes which is pretty good (we could do better if wanted I guess):

  • Au(i32) length;
  • f32 percentage;
  • AllowedNumericType(u8) clamping_mode;
  • bool has_percentage;
  • bool was_calc;

This will allow me to start moving C++ stuff to use this representation.

Priority: -- → P3
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9b729145045d
Represent the percentage in LengthPercentage with something other than an option. r=firefox-style-system-reviewers,boris
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.