Remove ondialoghelp attribute from xul files

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P3
normal
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: vinoth, Assigned: vinoth)

Tracking

(Blocks 1 bug)

unspecified
mozilla66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 attachment)

In order to remove the usage of new Function from dialog.xml[1], we need to remove the usage of attribute ondialoghelp[2] from all the places within our codebase.

[1] - https://dxr.mozilla.org/mozilla-central/rev/c291143e24019097d087f9307e59b49facaf90cb/toolkit/content/widgets/dialog.xml#418

[2] - https://dxr.mozilla.org/mozilla-central/search?q=ondialoghelp&redirect=false

Assignee

Updated

4 months ago
Assignee: nobody → cegvinoth
Blocks: 1473549
Status: NEW → ASSIGNED
Whiteboard: [domsecurity-active]
Assignee

Updated

4 months ago
Keywords: checkin-needed

Comment 2

4 months ago

Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/63d80647ebd2
Remove ondialoghelp attribute and add custom event handler r=Gijs

Keywords: checkin-needed

Comment 3

4 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
https://hg.mozilla.org/projects/cedar/rev/63d80647ebd20539391f9c7293b98d77cefeaec7
Bug 1521040 - Remove ondialoghelp attribute and add custom event handler r=Gijs

Updated

3 months ago
Depends on: 1532685
You need to log in before you can comment on or make changes to this bug.