Closed
Bug 1521044
Opened 7 years ago
Closed 7 years ago
Remove redundant theme-fg-color classes
Categories
(DevTools :: Inspector, enhancement, P3)
DevTools
Inspector
Tracking
(firefox66 fixed)
RESOLVED
FIXED
Firefox 66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: fvsch, Assigned: fvsch)
Details
Attachments
(1 file)
Searching through the CSS codebase, it seems we're always styling the theme-fg-color5 exactly like theme-fg-color3. We may have reduced the number of displayed colors in the past.
So we can deduplicate those.
Same for theme-fg-color2 which is only used once and styled like theme-fg-color1.
|
Assignee | |
Updated•7 years ago
|
Summary: Remove theme-fg-color5 class (duplicate of theme-fg-color3) → Remove redundant theme-fg-color classes
|
|
Assignee | |
Comment 1•7 years ago
|
||
|
|
Assignee | |
Comment 2•7 years ago
|
||
In this patch I'm keeping 3 theme-fg-color* classes:
theme-fg-color1: wastheme-fg-color1(no change, 8 uses in JS) andtheme-fg-color2(1 use in JS).theme-fg-color2: wastheme-fg-color4(renamed to fill the gap; 1 use in JS).theme-fg-color3: wastheme-fg-color3(no change, 3 uses in JS) andtheme-fg-color5(9 uses in JS).
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → florens
Status: NEW → ASSIGNED
|
||
Updated•7 years ago
|
Priority: -- → P3
Pushed by florens@fvsch.com:
https://hg.mozilla.org/integration/autoland/rev/58e82b793e1c
Remove redundant theme-fg-color classes; r=pbro
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
|
|
||
Comment 5•7 years ago
|
||
https://hg.mozilla.org/projects/cedar/rev/58e82b793e1cedafc925c346d407f6dfe9b6781c
Bug 1521044 - Remove redundant theme-fg-color classes; r=pbro
You need to log in
before you can comment on or make changes to this bug.
Description
•