[RTL] Force LTR on domain names under Trackers
Categories
(Firefox :: Site Identity, defect, P3)
Tracking
()
People
(Reporter: itiel_yn8, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
(Keywords: rtl, Whiteboard: [anti-tracking][qa-66b-p2])
Attachments
(2 files)
48.17 KB,
image/png
|
Details | |
47 bytes,
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta+
|
Details | Review |
In this panel, if the domain name starts with a number (like in the attached screenshot) or with RTL characters, the domain name will appear in reverse.
To fix this, the domain names should be hardcoded to LTR, as all domain names must (and should) always be LTR anyways.
This does not seem to affect the Cookies panel, as all domain name are preceding by the website protocol (https etc).
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ab2e6118d3ff Ensure that the labels we use to display origin names in Trackers/Cookies subpanels are always LTR but their text alignment follows UI directionality; r=johannh
Comment 3•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Assignee | ||
Comment 4•5 years ago
|
||
Comment on attachment 9039658 [details]
Bug 1521053 - Ensure that the labels we use to display origin names in Trackers/Cookies subpanels are always LTR but their text alignment follows UI directionality;
Beta/Release Uplift Approval Request
Feature/Bug causing the regression
User impact if declined
See screenshot. This is an edge case bug for RTL locales.
Is this code covered by automated tests?
No
Has the fix been verified in Nightly?
Yes
Needs manual test from QE?
No
If yes, steps to reproduce
List of other uplifts needed
None
Risk to taking this patch
Low
Why is the change risky/not risky? (and alternatives if risky)
Very simple CSS fix which has baked in Nightly
String changes made/needed
None
Updated•5 years ago
|
Comment 5•5 years ago
|
||
Comment on attachment 9039658 [details]
Bug 1521053 - Ensure that the labels we use to display origin names in Trackers/Cookies subpanels are always LTR but their text alignment follows UI directionality;
CSS fix for a LTR edge case.
Let's uplift for beta 6.
Comment 6•5 years ago
|
||
bugherder uplift |
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Description
•