[RTL] Force LTR on domain names under Trackers

RESOLVED FIXED in Firefox 66

Status

()

defect
P3
normal
RESOLVED FIXED
7 months ago
6 months ago

People

(Reporter: itiel_yn8, Assigned: Ehsan)

Tracking

(Blocks 1 bug, {rtl})

unspecified
Firefox 67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 wontfix, firefox66 fixed, firefox67 fixed)

Details

(Whiteboard: [anti-tracking][qa-66b-p2])

Attachments

(2 attachments)

Posted image Screenshot

In this panel, if the domain name starts with a number (like in the attached screenshot) or with RTL characters, the domain name will appear in reverse.
To fix this, the domain names should be hardcoded to LTR, as all domain names must (and should) always be LTR anyways.

This does not seem to affect the Cookies panel, as all domain name are preceding by the website protocol (https etc).

Blocks: privacy-ui
Priority: -- → P3
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox 66
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ab2e6118d3ff
Ensure that the labels we use to display origin names in Trackers/Cookies subpanels are always LTR but their text alignment follows UI directionality; r=johannh
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Whiteboard: [anti-tracking]

Comment on attachment 9039658 [details]
Bug 1521053 - Ensure that the labels we use to display origin names in Trackers/Cookies subpanels are always LTR but their text alignment follows UI directionality;

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1501991

User impact if declined

See screenshot. This is an edge case bug for RTL locales.

Is this code covered by automated tests?

No

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

No

If yes, steps to reproduce

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

Very simple CSS fix which has baked in Nightly

String changes made/needed

None

Attachment #9039658 - Flags: approval-mozilla-beta?

Comment on attachment 9039658 [details]
Bug 1521053 - Ensure that the labels we use to display origin names in Trackers/Cookies subpanels are always LTR but their text alignment follows UI directionality;

CSS fix for a LTR edge case.
Let's uplift for beta 6.

Attachment #9039658 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Whiteboard: [anti-tracking] → [anti-tracking][qa-66b-p2]
Target Milestone: Firefox 66 → Firefox 67
You need to log in before you can comment on or make changes to this bug.