Closed Bug 1521062 Opened 8 months ago Closed 7 months ago

Configure assembly builds of dav1d library on Windows

Categories

(Core :: Audio/Video: Playback, enhancement, P2)

x86_64
Windows
enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: achronop, Assigned: achronop)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

Activate assembly builds of libdav1d on windows. It requires modifications in build and configuration files of libdav1d. The aim is to build and try it locally. When Bug 1511224 is landed we can test on try too.

Attached file dav1d-asm-in-windows (obsolete) —

Build assembly files of libdav1d. It has been tested locally. I am waiting on Bug 1511224 to test on try.

Attached patch dav1d-asm-in-windows (obsolete) — Splinter Review

Build assembly files of libdav1d for Windows, rebased after latest changes on Bug 1515641. Still waiting on Bug 1511224.

Attachment #9041757 - Attachment is patch: true
Attachment #9041757 - Attachment mime type: application/octet-stream → text/plain
Attachment #9039100 - Attachment is obsolete: true

I have been testing today with patches from Bug 1511224. Most of the builds are green now. This is what we have so far:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e6c5a7509f732190a12994602a79bc4a6b58e7bc
plus the one fixing the win 32 builds:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bcd97782813732692ce65d12fb6c18cdd84d1d4e

We are missing only MinGW32/64 and the L10n for Windows 2012 opt 32/64.

I have tested all the binaries from try so far without an issue. Also Bryce was kind enough to test the Aarch64 binary for me which is also fine (note no ASM builds in aarch64 - that will be done on a separate bug).

Depends on: 1529305

Now that plain-opt is fixed, let's just turn off nasm on mingw32 builds for right now. I'm still working on a fix but I don't want to delay the assembly more.

We are having a green try with latest patch on Bug 1529305.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ca596aefaa80d58bdd74345a58a37fe2478f4ec

The MinGW 64 build works well.

The MinGW 32 build crashes after a few seconds. It looks like a dav1d issue. The video works for a few seconds and then crashes. I'll turn off nasm on MinGW 32 in order to move on with the assembly and will investigate the crash after.

Attachment #9041757 - Attachment is obsolete: true
Pushed by achronopoulos@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5fb9ad2446bc
Configure assembly builds for libdav1d on Windows. r=TD-Linux
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.