Closed Bug 1521084 Opened 9 months ago Closed 8 months ago

Make opt-out button work about:preferences if users are not enrolled in an experiment

Categories

(Firefox :: New Tab Page, defect, P2)

defect

Tracking

()

VERIFIED FIXED
Firefox 67
Iteration:
67.1 - Jan 28 - Feb 10
Tracking Status
firefox66 --- unaffected
firefox67 --- verified
firefox68 --- verified

People

(Reporter: andreio, Assigned: Mardak)

References

Details

(Keywords: github-merged)

Attachments

(3 files)

Bug 1515078 added special handing for discoverystream.config pref hiding some preferences options and the way we handle defaults. This needs to be updated once the experiment ends or if the pref value changes.

Discussion https://phabricator.services.mozilla.com/D16539#inline-91023

Iteration: --- → 67.1 - Jan 28 - Feb 10
Priority: -- → P2
Blocks: 1523703

I think it would be nice to have some kind of functional opt-out if we turn on the experience by default in nightly.

We'll have an explicit opt-out pref that we'll check for now but stop checking when we no longer want to allow opt out.

Assignee: nobody → edilee
Summary: Cleanup pref experiment code in about:preferences → Make opt-out button work about:preferences if users are not enrolled in an experiment

[Tracking Requested - why for this release]:

Blocks: 1525452
Status: NEW → RESOLVED
Closed: 8 months ago
Keywords: github-merged
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Blocks: 1526066

QA steps:

  1. open new tab with new pocket experience default on in nightly 67
  2. open preferences -> Home -> Turn Off Content Discovery
  3. make sure new tabs show previous pocket experience and highlights
  4. also make sure preferences show previous Home preferences even after refreshing

I have verified that this issue is no longer reproducible with the latest Firefox Beta (67.0b9 Build ID - 20190408123043) and with the latest Firefox Nightly (68.0a1 Build ID - 20190410215612) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, the default new tab experience is displayed after the "Turn Off Content Discovery" button is clicked.

Status: RESOLVED → VERIFIED
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.