Closed Bug 1521103 Opened 6 years ago Closed 6 years ago

maybeInjectSpocs throws on undefined spocs breaking the page for some endpoints

Categories

(Firefox :: New Tab Page, enhancement, P1)

Product:
Firefox
Component:
New Tab Page
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 66
Iteration:
66.3 - Jan 7 - 20
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: Mardak, Assigned: thecount)

References

Details

(Keywords: github-merged, Whiteboard: [export defect])

Setting layout endpoint to use dev-test-all (or dev-test-styles) and enabling discovery stream seems to be enough to trigger this right now. The endpoint does seem to have a top level spocs entry.

https://github.com/mozilla/activity-stream/commit/272b2ba2bcc75448228a956dc948d7eec4d16711#r31990857

Potentially it's a server json providing bad data issue? But we should also be more resilient on the client too.

Assignee: nobody → sdowne
Blocks: 1521093
Priority: -- → P1
See Also: → https://github.com/mozilla/activity-stream/pull/4684
Whiteboard: [export defect]

https://hg.mozilla.org/mozilla-central/rev/381457de43c0

Status: NEW → RESOLVED
Iteration: --- → 66.3 - Jan 7 - 20
Closed: 6 years ago
status-firefox66: --- → fixed
Keywords: github-merged
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66

Hi,

Can you pls provide QA steps?

Thanks,
Mini

Flags: needinfo?(edilee)
Flags: needinfo?(edilee) → needinfo?(sdowne)

No additional steps are needed for this beyond enable DiscoveryStream and ensuring the new tab page does not crash.

Status: RESOLVED → VERIFIED
Flags: needinfo?(sdowne)
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.