Closed
Bug 1521103
Opened 5 years ago
Closed 5 years ago
maybeInjectSpocs throws on undefined spocs breaking the page for some endpoints
Categories
(Firefox :: New Tab Page, enhancement, P1)
Firefox
New Tab Page
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: Mardak, Assigned: thecount)
References
Details
(Keywords: github-merged, Whiteboard: [export defect])
Setting layout endpoint to use dev-test-all (or dev-test-styles) and enabling discovery stream seems to be enough to trigger this right now. The endpoint does seem to have a top level spocs entry.
https://github.com/mozilla/activity-stream/commit/272b2ba2bcc75448228a956dc948d7eec4d16711#r31990857
Potentially it's a server json providing bad data issue? But we should also be more resilient on the client too.
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → sdowne
|
||
Comment 1•5 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/d0365c33031a3bc6f6ef0ab6c2ad4471c5bc0890 Bug 1521103 - Fixing spoc prop (#4684)
|
Reporter | |
Comment 2•5 years ago
|
||
Status: NEW → RESOLVED
Iteration: --- → 66.3 - Jan 7 - 20
Closed: 5 years ago
status-firefox66:
--- → fixed
Keywords: github-merged
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
|
|
Reporter | |
Updated•5 years ago
|
Flags: needinfo?(edilee) → needinfo?(sdowne)
|
|
Assignee | |
Comment 4•5 years ago
|
||
No additional steps are needed for this beyond enable DiscoveryStream and ensuring the new tab page does not crash.
Status: RESOLVED → VERIFIED
Flags: needinfo?(sdowne)
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•