Closed Bug 1521140 Opened 2 years ago Closed 2 years ago

In WPT reftest screenshot data-URI logging, the second data URI has "Pausing until the browser exits" added to the end of it


(Testing :: web-platform-tests, defect)

Version 3
Not set


(firefox66 fixed)

Tracking Status
firefox66 --- fixed


(Reporter: dholbert, Assigned: jgraham)



(2 files)

Attached file mylog.txt


  1. Run the following, using a reftest that is known to fail:
./mach test --reftest-screenshot=fail \
--log-tbpl mylog.txt  testing/web-platform/tests/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-justify-content-horiz-001b.xhtml

(Use some test that is known/expected to fail; this particular one may start passing when bug 1520946 lands in the next few days.)

  1. Inspect your log file.

ACTUAL RESULTS: In my case, the line with the second data URI ends with the string "Pausing until the browser exits". It looks like this (I've ellipsized the data for brevity):

REFTEST   IMAGE 2 (REFERENCE): data:image/png;base64,iVBO[...]YII=Pausing until the browser exits

Logging like "Pausing until the browser exits" should go on its own line

In case it matters, I'm using a debug build (ac_add_options --enable-debug --disable-optimize), built from this cset:

At first I suspected that maybe there was a race condition involved with some randomness, but FWIW, this happened to me three times in a row (i.e. I performed the STR 3x, using three different log files, and all three had this issue).

So it seems to be 100% reproducible at least on my end.

This breaks reftest-analyzer[1], as you might expect. In particular: if you...

  1. copypaste the three lines starting with "TEST-FAIL" from my attached log into reftest-analyzer.xhtml (including this bug's "Pausing" junk at the end of the third line)
  2. Manually do s/TEST-FAIL/TEST-KNOWN-FAIL/ as-needed per bug 1521147

...then reftest-analyzer will happily process your submission, but it shows "image not available" when you try to view the second image.


Pushed by
Ensure reftest screenshots are followed by a newline when expected, r=ahal
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Bug 1521140 - Ensure reftest screenshots are followed by a newline when expected, r=ahal
You need to log in before you can comment on or make changes to this bug.