Closed Bug 1521157 Opened 6 years ago Closed 6 years ago

Create a prototype UI to display the overall health of a push

Categories

(Tree Management :: Push Health, enhancement, P1)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: camd, Assigned: camd)

Details

Attachments

(15 files)

47 bytes, text/x-github-pull-request
ahal
: feedback+
kthiessen
: feedback+
aryx
: feedback+
Details | Review
47 bytes, text/x-github-pull-request
Details | Review
47 bytes, text/x-github-pull-request
Details | Review
47 bytes, text/x-github-pull-request
Details | Review
47 bytes, text/x-github-pull-request
Details | Review
47 bytes, text/x-github-pull-request
Details | Review
47 bytes, text/x-github-pull-request
Details | Review
47 bytes, text/x-github-pull-request
Details | Review
47 bytes, text/x-github-pull-request
Details | Review
47 bytes, text/x-github-pull-request
Details | Review
47 bytes, text/x-github-pull-request
Details | Review
47 bytes, text/x-github-pull-request
Details | Review
47 bytes, text/x-github-pull-request
Details | Review
47 bytes, text/x-github-pull-request
Details | Review
47 bytes, text/x-github-pull-request
Details | Review

This will be broken down into "metrics" for each category that determines if the health is "good to merge" or not.

Assignee: nobody → cdawson
Status: NEW → ASSIGNED
Priority: -- → P1
Attachment #9037651 - Flags: feedback?(jmaher)
Attachment #9037651 - Flags: feedback?(ahal)
Attachment #9037651 - Flags: feedback?(kthiessen)
Attachment #9037651 - Flags: feedback?(aryx.bugmail)

No rush on the feedback request. I mostly wanted to give you each a heads up into where I am and give you the opportunity to give some feedback. This is all very malleable at the moment, of course. So feedback welcome any time. :)

I like the UI, I would like to make sure we design this so we can:

  1. analyze data for each area
  2. provide next steps for each area (ideally actions like adding tests, retriggering, matching with bugzilla, etc.)

if we design with this in mind it will help the code and hacking as we iterate on this.

I still want to know what data we expect back. For example, if there are failed tests would the API return the failed tests? Would it return suggested next steps or bugs? I don't want an answer now, but this could influence the design- my thoughts are figuring that out before we get too far along will prevent issues.

Thanks for putting this up, I am working on the API :)

Attachment #9037651 - Flags: feedback?(jmaher)

Not sure how much of this feedback already belongs here:

Header:
Revision hashes are mostly meaningless in the sense most people won't be able to use them to identify one of several Try pushes. For identification, timestamp and last revisions should also be shown (on Try, the last revision is likely just the change to the Try config, the parent revision might have a meaningful commit message).
For later:
The sections in the body can we long enough to be partially hidden if there are test failures (and later e.g. the overall score at the top, UI to retrigger tests or links how to fix a linting failure etc.) A small horizontal bar at the top below the id section for the push which links to each section of results with a background color for the status.
Show progress of the push.

Stylistic nit-pick:
If the button to toggle the expansion state of each section is before the title, the buttons are nicely aligned and one can use them just by going up and down and clicking without the need for horizontal movement.

Content of each section TBD.

Attachment #9037651 - Flags: feedback?(kthiessen) → feedback+

Commented inline on GitHub. Joel tells me he is working on the API plumbing (and I see that he has commented here to that effect) so I think this is good progress.

+1 to aligning the buttons if possible.

Attachment #9037651 - Flags: feedback?(ahal) → feedback+

This prototype is at MVP (Minimum Viable Product) stage now. I will continue to add features, but I think I can mark this bug fixed. I'll open new bugs for future work.

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Component: Treeherder: Frontend → Push Health
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: