Closed Bug 1521189 Opened 5 years ago Closed 5 years ago

Asynchronously destroy WindowGlobalChild

Categories

(Core :: DOM: Core & HTML, defect, P2)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: nika, Assigned: nika)

References

Details

Attachments

(1 file)

Bug 1521189 - Asynchronously destroy WindowGlobalChild,
47 bytes, text/x-phabricator-request
Details | Review
No description provided.
Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/36b36b5cdab6
Asynchronously destroy WindowGlobalChild, r=farre

Backed out changeset 36b36b5cdab6 (Bug 1521189) for causing multiple application crashes in various tests CLOSED TREE.

Problematic push: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=36b36b5cdab6c75c1cfd7e0e7c4784c297c2efa2

Failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=36b36b5cdab6c75c1cfd7e0e7c4784c297c2efa2&selectedJob=223332723

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=223332723&repo=autoland&lineNumber=1489

[task 2019-01-22T18:43:51.407Z] 18:43:51 INFO -
[task 2019-01-22T18:43:51.408Z] 18:43:51 INFO - #17: main [browser/app/nsBrowserApp.cpp:265]
[task 2019-01-22T18:43:51.409Z] 18:43:51 INFO -
[task 2019-01-22T18:43:51.410Z] 18:43:51 INFO - #18: libc.so.6 + 0x20830
[task 2019-01-22T18:43:51.411Z] 18:43:51 INFO -
[task 2019-01-22T18:43:51.412Z] 18:43:51 INFO - #19: _start
[task 2019-01-22T18:43:51.413Z] 18:43:51 INFO -
[task 2019-01-22T18:43:51.432Z] 18:43:51 INFO - REFTEST INFO | Reading manifest file:///builds/worker/workspace/build/tests/reftest/tests/testing/crashtest/crashtests.list
[task 2019-01-22T18:43:51.448Z] 18:43:51 INFO - REFTEST INFO | Dumping JSON representation of sandbox
[task 2019-01-22T18:43:51.448Z] 18:43:51 INFO - REFTEST INFO | {"isDebugBuild":true,"xulRuntime":{"widgetToolkit":"gtk3","OS":"Linux","XPCOMABI":"x86_64-gcc3"},"smallScreen":false,"d2d":false,"dwrite":false,"gpuProcess":false,"azureCairo":false,"azureSkia":true,"skiaContent":true,"azureSkiaGL":0,"contentSameGfxBackendAsCanvas":true,"layersGPUAccelerated":false,"d3d11":false,"d3d9":false,"layersOpenGL":false,"webrender":false,"layersOMTC":true,"advancedLayers":false,"layerChecksEnabled":true,"retainedDisplayList":true,"Android":false,"cocoaWidget":false,"gtkWidget":true,"qtWidget":false,"winWidget":false,"is64Bit":true,"transparentScrollbars":true,"AddressSanitizer":false,"webrtc":true,"retainedDisplayLists":true,"compareRetainedDisplayLists":false,"skiaPdf":false,"release_or_beta":false,"http":{"userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:66.0) Gecko/20100101 Firefox/66.0","appName":"Mozilla","appVersion":"5.0","platform":"X11","oscpu":"Linux x86_64","misc":"rv:66.0"},"haveTestPlugin":true,"windowsDefaultTheme":false,"nativeThemePref":true,"gpuProcessForceEnabled":false,"prefs":{},"browserIsRemote":true,"asyncPan":true,"usesRepeatResampling":false,"verify":false,"serviceWorkerE10s":false}
[task 2019-01-22T18:43:54.393Z] 18:43:54 ERROR - REFTEST ERROR | Harness startup left crash dumps behind, but we weren't expecting it to!
[task 2019-01-22T18:43:54.395Z] 18:43:54 INFO - REFTEST INFO | Found unexpected crash dump file /tmp/tmp6wdQLi.mozrunner/minidumps/06f75afd-e5a3-db40-c7a3-664134182522.extra
[task 2019-01-22T18:43:54.399Z] 18:43:54 INFO - REFTEST INFO | Found unexpected crash dump file /tmp/tmp6wdQLi.mozrunner/minidumps/00a50913-455d-3e62-6d9f-f1262e50bb24.extra
[task 2019-01-22T18:43:54.399Z] 18:43:54 INFO - REFTEST INFO | Found unexpected crash dump file /tmp/tmp6wdQLi.mozrunner/minidumps/00a50913-455d-3e62-6d9f-f1262e50bb24.dmp
[task 2019-01-22T18:43:54.400Z] 18:43:54 INFO - REFTEST INFO | Found unexpected crash dump file /tmp/tmp6wdQLi.mozrunner/minidumps/06f75afd-e5a3-db40-c7a3-664134182522.dmp
[task 2019-01-22T18:43:55.063Z] 18:43:55 INFO - REFTEST SUITE-START | Running 3672 tests
[task 2019-01-22T18:43:55.064Z] 18:43:55 INFO - REFTEST TEST-START | data:text/html,
[task 2019-01-22T18:43:55.070Z] 18:43:55 INFO - REFTEST TEST-LOAD | data:text/html, | 0 / 3672 (0%)
[task 2019-01-22T18:43:55.071Z] 18:43:55 INFO - ###!!! [Parent][RunMessage] Error: Channel error: cannot send/recv
[task 2019-01-22T18:43:55.072Z] 18:43:55 INFO - ###!!! [Parent][RunMessage] Error: Channel error: cannot send/recv
[task 2019-01-22T18:43:55.073Z] 18:43:55 INFO - ###!!! [Parent][RunMessage] Error: Channel error: cannot send/recv
[task 2019-01-22T18:43:55.073Z] 18:43:55 INFO - ###!!! [Parent][RunMessage] Error: Channel error: cannot send/recv
[task 2019-01-22T18:43:55.074Z] 18:43:55 INFO - ###!!! [Parent][RunMessage] Error: Channel error: cannot send/recv
[task 2019-01-22T18:43:55.075Z] 18:43:55 INFO - ###!!! [Parent][RunMessage] Error: Channel error: cannot send/recv
[task 2019-01-22T18:43:55.076Z] 18:43:55 INFO - ###!!! [Parent][RunMessage] Error: Channel error: cannot send/recv
[task 2019-01-22T18:43:55.077Z] 18:43:55 INFO - ###!!! [Parent][RunMessage] Error: Channel error: cannot send/recv
[task 2019-01-22T18:43:55.078Z] 18:43:55 INFO - ###!!! [Parent][RunMessage] Error: Channel error: cannot send/recv
[task 2019-01-22T18:43:55.079Z] 18:43:55 INFO - ###!!! [Parent][RunMessage] Error: Channel error: cannot send/recv
[task 2019-01-22T18:43:55.079Z] 18:43:55 INFO - ###!!! [Parent][RunMessage] Error: Channel error: cannot send/recv
[task 2019-01-22T18:43:55.081Z] 18:43:55 INFO - ###!!! [Parent][RunMessage] Error: Channel error: cannot send/recv
[task 2019-01-22T18:43:55.082Z] 18:43:55 INFO - ###!!! [Parent][RunMessage] Error: Channel error: cannot send/recv
[task 2019-01-22T18:43:55.086Z] 18:43:55 INFO - ###!!! [Parent][RunMessage] Error: Channel error: cannot send/recv

Flags: needinfo?(nika)
Backout by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/69a279908152
Backed out changeset 36b36b5cdab6 for causing multiple application crashes in various tests CLOSED TREE.
https://hg.mozilla.org/projects/cedar/rev/69a2799081521866febfe2bbcbfc27b3d60133bd
Backed out changeset 36b36b5cdab6 (bug 1521189) for causing multiple application crashes in various tests CLOSED TREE.
Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1e68675bce75
Asynchronously destroy WindowGlobalChild, r=farre
Flags: needinfo?(nika)

https://hg.mozilla.org/mozilla-central/rev/1e68675bce75

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Backout by aciure@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/7ea32bdfebf1
Backed out changeset 1e68675bce75 for causing browser_dbg_rr_breakpoints-01.js to perma fail a=backout

Sorry for the late notice.

Backed out for causing browser_dbg_rr_breakpoints-01.js to perma fail:

https://hg.mozilla.org/mozilla-central/rev/7ea32bdfebf13efa1c11d817eb73f7a4d2654c36

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel%2Cretry&group_state=expanded&revision=1e68675bce75e958c4d6a7f14a021cbd914b2a9c
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=224136407&repo=autoland

15:46:17 INFO - TEST-START | devtools/client/webreplay/mochitest/browser_dbg_rr_breakpoints-01.js
15:46:17 INFO - GECKO(897) | MIDDLEMAN 903 /var/folders/04/6vrqht253lj8rws1wfkgy_tm00000x/T/TempRecording.897.1
15:46:17 INFO - GECKO(897) | RECORDING 904 /var/folders/04/6vrqht253lj8rws1wfkgy_tm00000x/T/TempRecording.897.1
15:46:18 INFO - GECKO(897) | REPLAYING 906 /var/folders/04/6vrqht253lj8rws1wfkgy_tm00000x/T/TempRecording.897.1
15:46:18 INFO - GECKO(897) | REPLAYING 907 /var/folders/04/6vrqht253lj8rws1wfkgy_tm00000x/T/TempRecording.897.1
15:46:18 INFO - GECKO(897) | ###!!! [Child][DispatchAsyncMessage] Error: PWindowGlobal::Msg___delete__ Route error: message sent to unknown actor ID
15:46:19 INFO - GECKO(897) | ###!!! [Parent][MessageChannel] Error: (msgtype=0x1E0088,name=PBrowser::Msg_Destroy) Channel error: cannot send/recv
15:46:31 INFO - GECKO(897) | 2019-01-25 15:46:31.865 firefox[897:8665] Persistent UI failed to open file file:///Users/cltbld/Library/Saved%20Application%20State/org.mozilla.nightly.savedState/window_1.data: No such file or directory (2)
15:47:02 INFO - TEST-INFO | started process screencapture
15:47:02 INFO - TEST-INFO | screencapture: exit 0
15:47:02 INFO - Buffered messages logged at 15:46:17
15:47:02 INFO - Entering test bound
15:47:02 INFO - Waiting for event: 'RecordingFinished' on [object ParentProcessMessageManager].
15:47:02 INFO - Buffered messages logged at 15:46:19
15:47:02 INFO - Console message: [JavaScript Error: "remote browser crashed while on about:blank
15:47:02 INFO - " {file: "chrome://mochikit/content/mochitest-e10s-utils.js" line: 8}]
15:47:02 INFO - e10s_init/<@chrome://mochikit/content/mochitest-e10s-utils.js:8:5
15:47:02 INFO - EventListener.handleEvente10s_init@chrome://mochikit/content/mochitest-e10s-utils.js:6:3
15:47:02 INFO - testInit@chrome://mochikit/content/browser-test.js:104:5
15:47:02 INFO - setTimeout handler@chrome://mochikit/content/browser-test.js:22:1
15:47:02 INFO - loadChromeScripts@jar:file:///var/folders/04/6vrqht253lj8rws1wfkgy_tm00000x/T/tmpoebwIR.mozrunner/extensions/mochikit@mozilla.org.xpi!/api.js:15:3
15:47:02 INFO - loadMochitest@jar:file:///var/folders/04/6vrqht253lj8rws1wfkgy_tm00000x/T/tmpoebwIR.mozrunner/extensions/mochikit@mozilla.org.xpi!/api.js:111:3
15:47:02 INFO - @tests/mochitest/runtests.py:1733:1
15:47:02 INFO - @tests/mochitest/runtests.py:1712:2
15:47:02 INFO - evaluate.sandbox/promise<@chrome://marionette/content/evaluate.js:130:13
15:47:02 INFO - evaluate.sandbox@chrome://marionette/content/evaluate.js:97:17
15:47:02 INFO - GeckoDriver.prototype.execute_@chrome://marionette/content/driver.js:1021:19

Status: RESOLVED → REOPENED
status-firefox66: fixed → ---
Flags: needinfo?(nika)
Resolution: FIXED → ---
Target Milestone: mozilla66 → ---

This test failure is a WebReplay test failure. Perhaps the correct path here is to disable the test, but I'm not sure what our current policy on WebReplay stuff is. ni? :bhackett for details

Flags: needinfo?(nika) → needinfo?(bhackett1024)

I've asked Nika to disable the test and reland the patch. We shouldn't be backing anything out due to WebReplay.

(In reply to :Nika Layzell from comment #10)

This test failure is a WebReplay test failure. Perhaps the correct path here is to disable the test, but I'm not sure what our current policy on WebReplay stuff is. ni? :bhackett for details

Feel free to disable the web replay tests whenever they start failing, this can be done in one line in devtools/client/webreplay/mochitest/browser.ini (see also bug 1517837). Thanks!

Flags: needinfo?(bhackett1024)
Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e8f9d3cdb231
Asynchronously destroy WindowGlobalChild, r=farre

Filed bug 1523364 & re-landing.

(In reply to Anthony Jones (:kentuckyfriedtakahe, :k17e) from comment #11)

I've asked Nika to disable the test and reland the patch. We shouldn't be backing anything out due to WebReplay.

I filed bug 1523492 to make these tests tier 2 and avoid future backouts.

https://hg.mozilla.org/mozilla-central/rev/e8f9d3cdb231

Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.