Stop overusing --panel-disabled-color in the Control Center

VERIFIED FIXED in Firefox 66

Status

()

defect
P1
normal
VERIFIED FIXED
5 months ago
4 months ago

People

(Reporter: dao, Assigned: johannh)

Tracking

(Blocks 1 bug)

Trunk
Firefox 67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65+ wontfix, firefox66+ verified, firefox67+ verified)

Details

Attachments

(1 attachment)

Reporter

Description

5 months ago

+++ This bug was initially created as a clone of Bug #1521231 +++

See bug 1520522 comment 3

Priority: -- → P2

Dão, were you planning on taking this bug? If not, do you have a recommendation for an alternative style we could use to achieve a slightly de-emphasized text in the control center like shown in https://mozilla.invisionapp.com/share/7TPU4WWJPUQ#/screens?

I know you and shorlander said in bug 1520522 that in some cases we may be able to use black instead, but there are certainly cases where we'd prefer grey, too. It would definitely be good to know the best way to do it.

Thanks!

Flags: needinfo?(dao+bmo)
Reporter

Comment 2

5 months ago

(In reply to Johann Hofmann [:johannh] from comment #1)

Dão, were you planning on taking this bug?

No.

If not, do you have a recommendation for an alternative style we could use to achieve a slightly de-emphasized text in the control center like shown in https://mozilla.invisionapp.com/share/7TPU4WWJPUQ#/screens?

I don't think there's a one-size-fits-all solution. This needs be decided on a case-by-case basis. Generally we should use the default color, and then we could use text size (the control center uses larger-than-normal text and could scale back to 100% for less important text) or indentation or separators to make the hierarchy clear. I don't think we need to de-emphasize the right-aligned pieces as the column design already makes things pretty clear.

Flags: needinfo?(dao+bmo)

If that is the case then we should make sure UX is aware that using de-emphasized text will basically make their design incompatible with MacOS.

[Tracking Requested - why for this release]:
Much of the control center is really hard to read on OSX. Provided that I can produce a harmless patch for this, I would love to be able to get it in alongside a dot release for 65.

Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Priority: P2 → P1

Sure, we can track this for a dot release ride-along. Won't make 65.0, though.

Not likely to make it into 65 at this point. Let's try again for 66.

Are you still working on this? I can take a low-risk patch for beta 66 but otherwise, for 67.

Flags: needinfo?(jhofmann)

Comment 8

4 months ago
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6bce33478b6b
Stop using --panel-disabled-color for identity popup state labels and the content blocking settings button. r=dao

Comment 9

4 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67

Comment on attachment 9046116 [details]
Bug 1521233 - Stop using --panel-disabled-color for identity popup state labels and the content blocking settings button. r=dao

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: Bug 1511878
  • User impact if declined: Bad text contrast in the control center on OSX
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Deleting a few lines of CSS
  • String changes made/needed: None
Flags: needinfo?(jhofmann)
Attachment #9046116 - Flags: approval-mozilla-beta?

Thanks for the reminder, Liz.

Comment on attachment 9046116 [details]
Bug 1521233 - Stop using --panel-disabled-color for identity popup state labels and the content blocking settings button. r=dao

CSS fix, OK for beta 12.

Attachment #9046116 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
QA Contact: ciprian.georgiu
Whiteboard: [qa-triaged]

Reproduced this bug using an affected Nightly build from 2019-01-18, on macOS 10.14.

I can confirm that the colors are disabled in the Control Center for identity popup state labels and settings button. The font (black on Default and Light Themes and white on Dark Theme) is properly displayed on Beta 66.0b12 and latest Nightly 67.0a1 under macOS 10.13 and 10.14.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
QA Whiteboard: [qa-triaged]
Whiteboard: [qa-triaged]
Reporter

Comment 15

4 months ago

This is not a regression.

Keywords: regression
You need to log in before you can comment on or make changes to this bug.