1521319 - Perma devtools/client/webconsole/test/mochitest/browser_jsterm_middle_click_paste.js | clipboard content was pasted in the console input - Got , expected test clipboard content

Status: VERIFIED FIXED

(DevTools :: Console, defect)

Description

[Arthur Iakab [arthur_iakab]]

[Tracking Requested - why for this release]:

https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=f1d5cf53e4ae4163666857f9cfa8f72ebd81f61f

This is occuring only on Nightly opt builds.
It seems that the failures started from this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1482875

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=222876610&repo=try

Part of that log:
[task 2019-01-19T14:00:35.905Z] 14:00:35 INFO - TEST-START | devtools/client/webconsole/test/mochitest/browser_jsterm_middle_click_paste.js
[task 2019-01-19T14:00:37.391Z] 14:00:37 INFO - TEST-INFO | started process screentopng
[task 2019-01-19T14:00:37.795Z] 14:00:37 INFO - TEST-INFO | screentopng: exit 0
[task 2019-01-19T14:00:37.795Z] 14:00:37 INFO - Buffered messages logged at 14:00:35
[task 2019-01-19T14:00:37.796Z] 14:00:37 INFO - Entering test bound
[task 2019-01-19T14:00:37.796Z] 14:00:37 INFO - Buffered messages logged at 14:00:36
[task 2019-01-19T14:00:37.796Z] 14:00:37 INFO - Adding a new tab with URL: data:text/html;charset=utf-8,Web Console test paste on middle-click
[task 2019-01-19T14:00:37.797Z] 14:00:37 INFO - Tab added and finished loading
[task 2019-01-19T14:00:37.797Z] 14:00:37 INFO - Opening the toolbox
[task 2019-01-19T14:00:37.798Z] 14:00:37 INFO - Buffered messages logged at 14:00:37
[task 2019-01-19T14:00:37.799Z] 14:00:37 INFO - Toolbox opened and focused
[task 2019-01-19T14:00:37.800Z] 14:00:37 INFO - Set clipboard content
[task 2019-01-19T14:00:37.800Z] 14:00:37 INFO - Middle-click on the console input
[task 2019-01-19T14:00:37.800Z] 14:00:37 INFO - Buffered messages finished
[task 2019-01-19T14:00:37.800Z] 14:00:37 INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/mochitest/browser_jsterm_middle_click_paste.js | clipboard content was pasted in the console input - Got , expected test clipboard content
[task 2019-01-19T14:00:37.800Z] 14:00:37 INFO - Stack trace:
[task 2019-01-19T14:00:37.800Z] 14:00:37 INFO - chrome://mochikit/content/browser-test.js:test_is:1318
[task 2019-01-19T14:00:37.800Z] 14:00:37 INFO - chrome://mochitests/content/browser/devtools/client/webconsole/test/mochitest/browser_jsterm_middle_click_paste.js:performTests:34
[task 2019-01-19T14:00:37.801Z] 14:00:37 INFO - Adding a new tab with URL: data:text/html;charset=utf-8,Web Console test paste on middle-click
[task 2019-01-19T14:00:37.801Z] 14:00:37 INFO - Tab added and finished loading
[task 2019-01-19T14:00:37.801Z] 14:00:37 INFO - Opening the toolbox
[task 2019-01-19T14:00:38.225Z] 14:00:38 INFO - Toolbox opened and focused
[task 2019-01-19T14:00:38.226Z] 14:00:38 INFO - Set clipboard content
[task 2019-01-19T14:00:38.227Z] 14:00:38 INFO - Middle-click on the console input
[task 2019-01-19T14:00:38.248Z] 14:00:38 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-01-19T14:00:38.251Z] 14:00:38 INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/mochitest/browser_jsterm_middle_click_paste.js | clipboard content was pasted in the console input - Got , expected test clipboard content
[task 2019-01-19T14:00:38.251Z] 14:00:38 INFO - Stack trace:
[task 2019-01-19T14:00:38.251Z] 14:00:38 INFO - chrome://mochikit/content/browser-test.js:test_is:1318
[task 2019-01-19T14:00:38.253Z] 14:00:38 INFO - chrome://mochitests/content/browser/devtools/client/webconsole/test/mochitest/browser_jsterm_middle_click_paste.js:performTests:34
[task 2019-01-19T14:00:38.254Z] 14:00:38 INFO - Leaving test bound
[task 2019-01-19T14:00:38.474Z] 14:00:38 INFO - Removing tab.
[task 2019-01-19T14:00:38.475Z] 14:00:38 INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2019-01-19T14:00:38.480Z] 14:00:38 INFO - Got event: 'TabClose' on [object XULElement].
[task 2019-01-19T14:00:38.484Z] 14:00:38 INFO - Tab removed and finished closing
[task 2019-01-19T14:00:38.674Z] 14:00:38 INFO - Removing tab.
[task 2019-01-19T14:00:38.675Z] 14:00:38 INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2019-01-19T14:00:38.683Z] 14:00:38 INFO - Got event: 'TabClose' on [object XULElement].
[task 2019-01-19T14:00:38.685Z] 14:00:38 INFO - Tab removed and finished closing
[task 2019-01-19T14:00:38.707Z] 14:00:38 INFO - GECKO(8469) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2019-01-19T14:00:38.708Z] 14:00:38 INFO - GECKO(8469) | MEMORY STAT | vsize 1825MB | residentFast 369MB | heapAllocated 145MB
[task 2019-01-19T14:00:38.709Z] 14:00:38 INFO - TEST-OK | devtools/client/webconsole/test/mochitest/browser_jsterm_middle_click_paste.js | took 2805ms
[task 2019-01-19T14:00:38.726Z] 14:00:38 INFO - checking window state

Comment 1

[Arthur Iakab [arthur_iakab]]

These are the beta simulations:

https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=f1d5cf53e4ae4163666857f9cfa8f72ebd81f61f&selectedJob=222876280&searchStr=linux%2Cnightly%2Copt%2Cmochitests%2Cwith%2Ce10s%2Ctest-linux32-nightly%2Fopt-mochitest-clipboard-e10s%2Cm-e10s%28cl%29

https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=eeee43603af9a263abcbb74552ef06b72e223a13&selectedJob=222876409&searchStr=linux%2Cnightly%2Copt%2Cmochitests%2Cwith%2Ce10s%2Ctest-linux32-nightly%2Fopt-mochitest-clipboard-e10s%2Cm-e10s%28cl%29

Nicolas could you please take a look?

Comment 2

[Intermittent Failures Robot]

15 failures in 2378 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 15

Platform breakdown:

• macosx64-nightly: 2
• linux32-nightly: 7
• linux64-nightly: 2
• windows10-64-nightly: 2
• windows7-32-nightly: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1521319&startday=2019-01-14&endday=2019-01-20&tree=all

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

There are 2 patches in Bug 1482875, are they both applied for the beta simulation?

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Yes. Yesterday's beta simulation which is also affected uses https://hg.mozilla.org/mozilla-central/rev/219bc50b5cd5ac8b374cac6531ece44dddf4bfff as base revision and that got pushed to mozilla-central at Sun, 20 Jan 2019 09:43:40 +0000

The screenshot (open the log and select the artifact which ends on ".png" shows the self xss check kicks in and prevents the pasting.

devtools.selfxss.count need to be set to 5 to fix this. It only has this value by default in Nightly and DevEdition.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1521319 - Disable selfXSS prevention for browser_jsterm_middle_click_paste.js

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1df92f5b3d7d
Disable selfXSS prevention for browser_jsterm_middle_click_paste.js r=nchevobbe

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/847eaa28d60b
Backed out changeset 1df92f5b3d7d for eslint failure in modified file.
https://hg.mozilla.org/integration/autoland/rev/2dd26100e311
Disable selfXSS prevention for browser_jsterm_middle_click_paste.js r=nchevobbe

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/2dd26100e311

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with today's central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=7999364358ddbd2b2cf5a942e649ea9dab2779fe&selectedJob=223250531

Comment 10

[Intermittent Failures Robot]

10 failures in 2383 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 10

Platform breakdown:

• windows7-32-nightly: 2
• linux64-nightly: 2
• macosx64-nightly: 2
• linux32-nightly: 2
• windows10-64-nightly: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1521319&startday=2019-01-21&endday=2019-01-27&tree=all