1521325 - TrackUnionStream.cpp: Value stored to 'inputTrackEndPoint' is never read

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Sylvestre Ledru [:Sylvestre]]

A good first bug to test the contribution workflow
http://sylvestre.ledru.info/reports/fx-scan-build/report-TrackUnionStream.cpp-CopyTrackData-24-1.html#EndPath
The line can probably be safely removed

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Note that we have (at least) three documentations to start contributing (esp with phabricator):
https://wiki.mozilla.org/Phabricator/FAQ
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch
https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

(something that we should improve at some point)

Comment 2

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

I've looked at the change suggested by the static analysis and agree.

The condition that triggers the line in question breaks out of the loop.

for (some range)
  value = foo

  if (condition) {
    value = bar // the line in question
    break;
  }

  /* use value */

end

So if the condition is triggered, we leave the loop before value is used.

Comment 3

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Attachment: Bug 1521325 - TrackUnionStream.cpp: Value stored to 'inputTrackEndPoint' is never read. r=padenot

This is a change suggested by static analysis: http://sylvestre.ledru.info/reports/fx-scan-build/report-TrackUnionStream.cpp-CopyTrackData-24-1.html#EndPath

The condition that triggers the line in question breaks out of the loop.

for (some range)
  value = foo

  if (condition) {
    value = bar // the line in question
    break;
  }

  /* use value */

end

So if the condition is triggered, we leave the loop before value is used.

Comment 4

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Local build and test confirmed. Requesting landing.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Should be marked as fixed only whem on mc

Comment 6

[Sylvestre Ledru [:Sylvestre]]

I used Lando

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce681d2ac834
TrackUnionStream.cpp: Value stored to 'inputTrackEndPoint' is never read. r=pehrsons

Comment 8

[Sylvestre Ledru [:Sylvestre]]

This is autoland, not mc

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ce681d2ac834