Closed Bug 1521325 Opened 10 months ago Closed 10 months ago

TrackUnionStream.cpp: Value stored to 'inputTrackEndPoint' is never read

Categories

(Core :: Audio/Video: Playback, defect, P3, trivial)

defect

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox66 --- wontfix
firefox67 --- fixed

People

(Reporter: Sylvestre, Assigned: emceeaich)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

A good first bug to test the contribution workflow
http://sylvestre.ledru.info/reports/fx-scan-build/report-TrackUnionStream.cpp-CopyTrackData-24-1.html#EndPath
The line can probably be safely removed

Note that we have (at least) three documentations to start contributing (esp with phabricator):
https://wiki.mozilla.org/Phabricator/FAQ
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch
https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

(something that we should improve at some point)

Priority: -- → P3

This is a change suggested by static analysis: http://sylvestre.ledru.info/reports/fx-scan-build/report-TrackUnionStream.cpp-CopyTrackData-24-1.html#EndPath

The condition that triggers the line in question breaks out of the loop.

for (some range)
  value = foo

  if (condition) {
    value = bar // the line in question
    break;
  }

  /* use value */

end

So if the condition is triggered, we leave the loop before value is used.

Local build and test confirmed. Requesting landing.

Status: NEW → RESOLVED
Closed: 10 months ago
Keywords: checkin-needed
Resolution: --- → FIXED

Should be marked as fixed only whem on mc

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Keywords: checkin-needed

I used Lando

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ce681d2ac834
TrackUnionStream.cpp: Value stored to 'inputTrackEndPoint' is never read. r=pehrsons
Status: REOPENED → RESOLVED
Closed: 10 months ago10 months ago
Resolution: --- → FIXED

This is autoland, not mc

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 10 months ago10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.