Fix adding extremely large primitives to picture caching tile dependencies.

RESOLVED FIXED in Firefox 66

Status

()

enhancement
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: gw, Assigned: gw)

Tracking

unspecified
mozilla66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

4 months ago

When adding an extremely large primitive to the picture caching tile dependencies, the existing code calculates the tile bounds, then iterates that loop, skipping tiles outside the the bounds.

This can be extremely slow in some edge cases, where the primitive world rect may be 10^9 or more.

The existing code is a leftover from when picture caching created tiles based on the bounding rect of the scene.

However, that's no longer the case - tiles are now created only around an approximate display port. Given then, we can easily clamp the calculated tile boundaries and only iterate those.

Assignee

Comment 2

4 months ago

Comment 3

4 months ago
Pushed by gwatson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/47e442ac35b3
Fix adding extremely large primitives to picture caching tile dependencies. r=jrmuizel

Comment 4

4 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Assignee: nobody → gwatson
You need to log in before you can comment on or make changes to this bug.