Closed Bug 1521363 Opened 5 years ago Closed 4 years ago

Intermittent browser/components/extensions/test/browser/test-oop-extensions/browser_ext_tabs_events.js | Expected removed tab ID - Expected: 445, Actual: 444 -

Categories

(WebExtensions :: Untriaged, defect, P5)

defect

Tracking

(firefox-esr68 fixed, firefox73 wontfix, firefox74 fixed, firefox75 fixed)

RESOLVED FIXED
mozilla75
Tracking Status
firefox-esr68 --- fixed
firefox73 --- wontfix
firefox74 --- fixed
firefox75 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: mixedpuppy)

References

(Blocks 2 open bugs)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Filed by: btara [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=222929857&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/OJ6Z8x4tQY-1E074HLF7Iw/runs/0/artifacts/public/logs/live_backing.log

[task 2019-01-20T08:29:42.142Z] 08:29:42 INFO - Close second window
[task 2019-01-20T08:29:42.144Z] 08:29:42 INFO - Expecting events: onRemoved
[task 2019-01-20T08:29:42.146Z] 08:29:42 INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_tabs_events.js | Got expected number of events - Expected: 1, Actual: 1 -
[task 2019-01-20T08:29:42.148Z] 08:29:42 INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_tabs_events.js | Got expected onRemoved event - Expected: onRemoved, Actual: onRemoved -
[task 2019-01-20T08:29:42.151Z] 08:29:42 INFO - Buffered messages finished
[task 2019-01-20T08:29:42.153Z] 08:29:42 INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_tabs_events.js | Expected removed tab ID - Expected: 445, Actual: 444 -
[task 2019-01-20T08:29:42.155Z] 08:29:42 INFO - Stack trace:
[task 2019-01-20T08:29:42.157Z] 08:29:42 INFO - chrome://mochikit/content/browser-test.js:test_ok:1307
[task 2019-01-20T08:29:42.159Z] 08:29:42 INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:testHandler:59
[task 2019-01-20T08:29:42.161Z] 08:29:42 INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:testResult:73
[task 2019-01-20T08:29:42.163Z] 08:29:42 INFO - chrome://mochikit/content/tests/SimpleTest/specialpowersAPI.js:listener:2100
[task 2019-01-20T08:29:42.165Z] 08:29:42 INFO - chrome://mochikit/content/tests/SimpleTest/specialpowersAPI.js:loadExtension/<:2033
[task 2019-01-20T08:29:42.167Z] 08:29:42 INFO - chrome://mochikit/content/tests/SimpleTest/ChromePowers.js:ChromePowers.prototype._sendReply:33
[task 2019-01-20T08:29:42.169Z] 08:29:42 INFO - chrome://mochikit/content/tests/SimpleTest/SpecialPowersObserverAPI.js:resultListener:574
[task 2019-01-20T08:29:42.172Z] 08:29:42 INFO - resource://gre/modules/ExtensionCommon.jsm:emit:310
[task 2019-01-20T08:29:42.174Z] 08:29:42 INFO - resource://gre/modules/Extension.jsm:receiveMessage:1488
[task 2019-01-20T08:29:42.175Z] 08:29:42 INFO - MessageListener.receiveMessage*resource://gre/modules/Extension.jsm:Extension:1332
[task 2019-01-20T08:29:42.175Z] 08:29:42 INFO - resource://testing-common/ExtensionTestCommon.jsm:generate:366
[task 2019-01-20T08:29:42.176Z] 08:29:42 INFO - chrome://mochikit/content/tests/SimpleTest/SpecialPowersObserverAPI.js:_receiveMessageAPI:571
[task 2019-01-20T08:29:42.177Z] 08:29:42 INFO - chrome://mochikit/content/tests/SimpleTest/ChromePowers.js:ChromePowers.prototype._receiveMessage:81
[task 2019-01-20T08:29:42.177Z] 08:29:42 INFO - chrome://mochikit/content/tests/SimpleTest/ChromePowers.js:ChromePowers.prototype._sendAsyncMessage:43
[task 2019-01-20T08:29:42.178Z] 08:29:42 INFO - chrome://mochikit/content/tests/SimpleTest/specialpowersAPI.js:loadExtension:2082
[task 2019-01-20T08:29:42.178Z] 08:29:42 INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:ExtensionTestUtils.loadExtension:105
[task 2019-01-20T08:29:42.179Z] 08:29:42 INFO - chrome://mochitests/content/browser/browser/components/extensions/test/browser/test-oop-extensions/browser_ext_tabs_events.js:test_tab_events_incognito_monitored:193
[task 2019-01-20T08:29:42.179Z] 08:29:42 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1108
[task 2019-01-20T08:29:42.180Z] 08:29:42 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1099
[task 2019-01-20T08:29:42.180Z] 08:29:42 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:997
[task 2019-01-20T08:29:42.181Z] 08:29:42 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-01-20T08:29:42.182Z] 08:29:42 INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_tabs_events.js | Expected removed tab window ID - Expected: 698, Actual: 698 -

I think the problem is assuming the ordering of the onCreated events here:
https://searchfox.org/mozilla-central/rev/153172de0c5bfca31ef861bd8fc0995f44cada6a/browser/components/extensions/test/browser/browser_ext_tabs_events.js#83

I guess the simplest fix would be to serialize the calls to browser.windows.create() instead of using Promise.all. Shane, you wrote this code, can you take this?

Flags: needinfo?(mixedpuppy)

For reasons that I didn't try to figure out, this became a permanent failure with bug 1555771, the test is now disabled until this gets fixed.

Assignee: nobody → mixedpuppy
Flags: needinfo?(mixedpuppy)
Pushed by scaraveo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8b4a4d993cf3
fix timing issue in tabs events test r=robwu
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Regressions: 1570526

Backing out based on comment 3 from Bug 1570526 https://bugzilla.mozilla.org/show_bug.cgi?id=1570526#c3

Backed out changeset 8b4a4d993cf3 (bug 1521363) for causing browser chrome faulures Bug 1570526

Backout revision https://hg.mozilla.org/integration/autoland/rev/dae072ac17ed5dea0c4ca2f5fa00ed7c5d618d7e

Failure logs https://treeherder.mozilla.org/logviewer.html#?job_id=259543709&repo=autoland

Part of that log:
[task 2019-08-02T09:50:46.000Z] 09:50:46 INFO - chrome://mochikit/content/browser-test.js:test_is:1591
[task 2019-08-02T09:50:46.000Z] 09:50:46 INFO - chrome://mochitests/content/browser/browser/components/extensions/test/browser/test-oop-extensions/browser_ext_tabs_events.js:checkDimensions:371
[task 2019-08-02T09:50:46.000Z] 09:50:46 INFO - chrome://mochitests/content/browser/browser/components/extensions/test/browser/test-oop-extensions/browser_ext_tabs_events.js:testTabEventsSize:391
[task 2019-08-02T09:50:46.000Z] 09:50:46 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1346
[task 2019-08-02T09:50:46.000Z] 09:50:46 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1381
[task 2019-08-02T09:50:46.000Z] 09:50:46 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1209
[task 2019-08-02T09:50:46.000Z] 09:50:46 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-08-02T09:50:46.000Z] 09:50:46 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-08-02T09:50:46.001Z] 09:50:46 INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_tabs_events.js | tab from onCreated reports expected width - Got 640, expected 1280
[task 2019-08-02T09:50:46.001Z] 09:50:46 INFO - Stack trace:
[task 2019-08-02T09:50:46.001Z] 09:50:46 INFO - chrome://mochikit/content/browser-test.js:test_is:1591
[task 2019-08-02T09:50:46.001Z] 09:50:46 INFO - chrome://mochitests/content/browser/browser/components/extensions/test/browser/test-oop-extensions/browser_ext_tabs_events.js:checkDimensions:366
[task 2019-08-02T09:50:46.001Z] 09:50:46 INFO - chrome://mochitests/content/browser/browser/components/extensions/test/browser/test-oop-extensions/browser_ext_tabs_events.js:testTabEventsSize:392
[task 2019-08-02T09:50:46.001Z] 09:50:46 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1346
[task 2019-08-02T09:50:46.001Z] 09:50:46 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1381
[task 2019-08-02T09:50:46.001Z] 09:50:46 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1209
[task 2019-08-02T09:50:46.001Z] 09:50:46 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-08-02T09:50:46.001Z] 09:50:46 INFO - Not taking screenshot here: see the one that was previously logged

Shane can you please take a look?

Status: RESOLVED → REOPENED
Flags: needinfo?(mixedpuppy)
Resolution: FIXED → ---
Target Milestone: mozilla70 → ---
Flags: needinfo?(mixedpuppy)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mixedpuppy, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(mixedpuppy)
Blocks: 1614075
Blocks: 1609072
Pushed by scaraveo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/030b2406e12c
fix timing issue in tabs events test r=robwu
Backout by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b59445753c25
Backed out changeset 030b2406e12c for causing raptor test failures CLOSED TREE

Are you certain this patch caused that? This is a test-only patch in BC, I'm not certain how it would have any effect on a raptor test.

Flags: needinfo?(mixedpuppy) → needinfo?(shindli)
Pushed by malexandru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b8476d9a1437
fix timing issue in tabs events test r=robwu
Status: REOPENED → RESOLVED
Closed: 5 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: