1521404 - Apilint shows lots of warning because it cannot find org.mozilla.geckoview.BuildConfig

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[Jan Henning [:JanH]]

Like below, only repeated 15 times (currently):

> /home/jan/Mozilla/mozilla-central/mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/GeckoHlsAudioRenderer.java:13: error: cannot find symbol
> import org.mozilla.geckoview.BuildConfig;
>                             ^
>   symbol:   class BuildConfig
>   location: package org.mozilla.geckoview

Those warnings aren't fatal, but they're still annoying and detract from whether the apilint run itself was successful or not.

Comment 1

[Agi Sferro | :agi | ⏰ PST | he/him]

Thanks for the report JanH! This is because we don't want BuildConfig to be part of the api and we skip it in here. I guess we can just not generate the api outline for that class instead.

Comment 2

[Agi Sferro | :agi | ⏰ PST | he/him]

Attachment: Bug 1521404 - Fix apilint warnings about BuildConfig.

See https://github.com/mozilla-mobile/gradle-apilint/commit/aa9e8a7a2337b3d76951e1bc78c653b51b9be188.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c997411e8d31
Fix apilint warnings about BuildConfig. r=geckoview-reviewers,snorp

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/c997411e8d31