1521416 - Thread pane icons not correct with dark theme

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

On Mac with dark theme some icons in the thread pane aren't correctly shown like the read and the flag icon. The thread icon is dark when the row is unselected.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1521416-mac-threadpane-icons.patch

Fix

Comment 2

[Arshad Khan [:arshad]]

Attachment: Screenshot 2019-01-21 at 7.44.36 PM.png

Hey I suppose the icons in this row are affected by this patch. I dont know how to see the css in devtools for treechildren element.. Visually I can see the difference this patch makes.

The svg that you added i.e., unread.svg, shouldn't it be named read.svg as the icon that appears when a msg is read is same as unread.svg?

Comment 3

[Richard Marti (:Paenglab)]

You can't inspect trees, they are special in this case.

Yes, unread.svg is wrong. I'll rename it to dot.svg as it is used for the flag too.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1521416-mac-threadpane-icons.patch

Same patch but with dot.svg.

Comment 5

[Arshad Khan [:arshad]]

Comment on attachment 9037974 [details] [diff] [review]
1521416-mac-threadpane-icons.patch

Review of attachment 9037974 [details] [diff] [review]:
-----------------------------------------------------------------

visually looks good to me.

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 9037974 [details] [diff] [review]
1521416-mac-threadpane-icons.patch

Review of attachment 9037974 [details] [diff] [review]:
-----------------------------------------------------------------

Drive-by questions ;-)

::: mail/themes/osx/mail/messageIcons.css
@@ -44,5 @@
>  }
>  
>  treechildren::-moz-tree-image(unreadButtonColHeader, unread) {
>    list-style-image: url(chrome://messenger/skin/icons/unreadmail.png) !important;
> -  -moz-image-region: auto !important;

Not needed any more?

@@ +82,5 @@
>  }
>  
>  treechildren::-moz-tree-image(flaggedCol) {
> +  list-style-image: url(chrome://messenger/skin/icons/dot.svg);
> +  -moz-image-region: auto

Region for an SVG?

Comment 7

[Richard Marti (:Paenglab)]

Attachment: 1521416-mac-threadpane-icons.patch

(In reply to Jorg K (GMT+1) from comment #6)

Comment on attachment 9037974 [details] [diff] [review]
1521416-mac-threadpane-icons.patch

Review of attachment 9037974 [details] [diff] [review]:

Drive-by questions ;-)

::: mail/themes/osx/mail/messageIcons.css
@@ -44,5 @@

}

treechildren::-moz-tree-image(unreadButtonColHeader, unread) {
list-style-image: url(chrome://messenger/skin/icons/unreadmail.png) !important;

• -moz-image-region: auto !important;

Not needed any more?

No, because it's added at treechildren::-moz-tree-image(unreadButtonColHeader) {}

@@ +82,5 @@

}

treechildren::-moz-tree-image(flaggedCol) {

• list-style-image: url(chrome://messenger/skin/icons/dot.svg);
• -moz-image-region: auto

Region for an SVG?

Yes, when there is from a other style a -moz-image-region set, we would see no icon. New patch because of the missing semicolon after auto.

Comment 8

[Richard Marti (:Paenglab)]

Comment on attachment 9038033 [details] [diff] [review]
1521416-mac-threadpane-icons.patch

When you plan a new beta, this could go there too.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ab66eaf0f575
Fix the thread pane icon with dark theme enabled. r=arshad

Comment 10

[Jorg K (CEST = GMT+2)]

TB 65 beta 4:
https://hg.mozilla.org/releases/comm-beta/rev/96dae5ff0c34d168a5cca855447aed5ed464fa7e