Closed Bug 1521416 Opened 9 months ago Closed 9 months ago

Thread pane icons not correct with dark theme

Categories

(Thunderbird :: Theme, defect)

All
macOS
defect
Not set

Tracking

(thunderbird65 fixed, thunderbird66 fixed)

RESOLVED FIXED
Thunderbird 66.0
Tracking Status
thunderbird65 --- fixed
thunderbird66 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files, 2 obsolete files)

On Mac with dark theme some icons in the thread pane aren't correctly shown like the read and the flag icon. The thread icon is dark when the row is unselected.

Fix

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9037861 - Flags: review?(arshdkhn1)

Hey I suppose the icons in this row are affected by this patch. I dont know how to see the css in devtools for treechildren element.. Visually I can see the difference this patch makes.

The svg that you added i.e., unread.svg, shouldn't it be named read.svg as the icon that appears when a msg is read is same as unread.svg?

You can't inspect trees, they are special in this case.

Yes, unread.svg is wrong. I'll rename it to dot.svg as it is used for the flag too.

Same patch but with dot.svg.

Attachment #9037861 - Attachment is obsolete: true
Attachment #9037861 - Flags: review?(arshdkhn1)
Attachment #9037974 - Flags: review?(arshdkhn1)
Comment on attachment 9037974 [details] [diff] [review]
1521416-mac-threadpane-icons.patch

Review of attachment 9037974 [details] [diff] [review]:
-----------------------------------------------------------------

visually looks good to me.
Attachment #9037974 - Flags: review?(arshdkhn1) → review+
Keywords: checkin-needed
Comment on attachment 9037974 [details] [diff] [review]
1521416-mac-threadpane-icons.patch

Review of attachment 9037974 [details] [diff] [review]:
-----------------------------------------------------------------

Drive-by questions ;-)

::: mail/themes/osx/mail/messageIcons.css
@@ -44,5 @@
>  }
>  
>  treechildren::-moz-tree-image(unreadButtonColHeader, unread) {
>    list-style-image: url(chrome://messenger/skin/icons/unreadmail.png) !important;
> -  -moz-image-region: auto !important;

Not needed any more?

@@ +82,5 @@
>  }
>  
>  treechildren::-moz-tree-image(flaggedCol) {
> +  list-style-image: url(chrome://messenger/skin/icons/dot.svg);
> +  -moz-image-region: auto

Region for an SVG?

(In reply to Jorg K (GMT+1) from comment #6)

Comment on attachment 9037974 [details] [diff] [review]
1521416-mac-threadpane-icons.patch

Review of attachment 9037974 [details] [diff] [review]:

Drive-by questions ;-)

::: mail/themes/osx/mail/messageIcons.css
@@ -44,5 @@

}

treechildren::-moz-tree-image(unreadButtonColHeader, unread) {
list-style-image: url(chrome://messenger/skin/icons/unreadmail.png) !important;

  • -moz-image-region: auto !important;

Not needed any more?

No, because it's added at treechildren::-moz-tree-image(unreadButtonColHeader) {}

@@ +82,5 @@

}

treechildren::-moz-tree-image(flaggedCol) {

  • list-style-image: url(chrome://messenger/skin/icons/dot.svg);
  • -moz-image-region: auto

Region for an SVG?

Yes, when there is from a other style a -moz-image-region set, we would see no icon. New patch because of the missing semicolon after auto.

Attachment #9037974 - Attachment is obsolete: true
Attachment #9038033 - Flags: review+
Comment on attachment 9038033 [details] [diff] [review]
1521416-mac-threadpane-icons.patch

When you plan a new beta, this could go there too.
Attachment #9038033 - Flags: approval-comm-beta?
Attachment #9038033 - Flags: approval-comm-beta? → approval-comm-beta+

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/ab66eaf0f575
Fix the thread pane icon with dark theme enabled. r=arshad

Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 66.0
You need to log in before you can comment on or make changes to this bug.