Links to comments are not correct in bugmail
Categories
(bugzilla.mozilla.org :: Email Notifications, defect)
Tracking
()
People
(Reporter: emk, Assigned: kohei)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(1 file)
Steps to reproduce:
Click this link in the bugmail: -> comment #0.
Actual result:
The Bugizlla Main Page will open.
Expected result:
This comment should open.
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 4•5 years ago
|
||
Any ETA on fixing this regression?
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 6•5 years ago
|
||
This bug and bug 832993 are both about relative URLs. In that other bug, the issue was caused by the lack of <base>
support.
In this case, <base>
is supported, but since the links only consist of a reference fragment (#c0
), and the <base>
element is <base href="https://bugzilla.mozilla.org/">
, the link points to the homepage, not the specific bug on which the comment was made.
Comment 7•5 years ago
|
||
Kohei, is that something you can help with?
Thanks
Assignee | ||
Comment 8•5 years ago
|
||
Will have a look today.
Assignee | ||
Comment 9•5 years ago
|
||
Assignee | ||
Comment 10•5 years ago
|
||
My PR won’t fix Bug 832993 which is a different issue from this regression.
The wrong links here are missing the path:
<a href="#c4">Comment 4</a>
With my fix, it will look like:
<a href="/show_bug.cgi?id=1521423#c4" title="NEW - Links to comments are not correct in bugmail">Comment 4</a>
It’s still a relative URL like other bug links.
Assignee | ||
Comment 11•5 years ago
|
||
Merged to master.
Description
•