1521481 - chat conversations number indicator showing funny bubbles with zero

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Magnus Melin [:mkmelin]]

+++ This bug was initially created as a clone of Bug #1519091 +++
Bug 1519091 made the main chat conversation browser work again, but after that, the conversations show a funny bubble with zero next to conversations with no new.

It's unclear if this is from that bug, or something that regressed during the time chat was broken. (Possibly something related to richlist/richlistitem.)

Starting point for debuggning: convUnreadTargetedCount: https://searchfox.org/comm-central/source/mail/components/im/content/imconv.xml#33

Comment 1

[Magnus Melin [:mkmelin]]

Jörg had a screenshot https://imgur.com/a/BR2E39w

Comment 2

[Florian Quèze [:florian]]

(In reply to Magnus Melin [:mkmelin] from comment #0)

It's unclear if this is from that bug, or something that regressed during the time chat was broken. (Possibly something related to richlist/richlistitem.)

I think it's the latter, as I can't reproduce on my local build on which I applied the patches from bug 1519091 to review them. I haven't pulled m-c/c-c since the review of the first version of that patch (I'm currently on revision 66b68c6b6221 on m-c, that's from Wednesday January 16).

Comment 3

[Richard Marti (:Paenglab)]

Or it could be because of bug 1444987 which added a box around the convUnreadTargetedCountLabel to make the border-radius apply.

Comment 4

[Patrick Cloke [:clokep]]

I suspect this is a regression from bug 1444987.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: 1521481-hide.unread-count.patch

This fixes it for me. Is there a more elegant way?

Comment 6

[Richard Marti (:Paenglab)]

The box needs the value to hide when it is "0", see https://searchfox.org/comm-central/source/mail/components/im/content/chat.css#38

Comment 7

[Florian Quèze [:florian]]

Comment on attachment 9037992 [details] [diff] [review]
1521481-hide.unread-count.patch

Review of attachment 9037992 [details] [diff] [review]:
-----------------------------------------------------------------

wfm, thanks!

Comment 8

[Richard Marti (:Paenglab)]

Comment on attachment 9037992 [details] [diff] [review]
1521481-hide.unread-count.patch

Regression from bug 1444987.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/51560879ea98
Hide chat conversation number indicator when its value is "0" by copying the xbl:inherits to the surrounding box. r=florian

Comment 10

[Jorg K (CEST = GMT+2)]

TB 65 beta 4:
https://hg.mozilla.org/releases/comm-beta/rev/fa0f40f25bae898175e89590f4c2d23770a49fb5