bash-completion.sh is too slow (mach issue?)
Categories
(Firefox Build System :: Mach Core, enhancement)
Tracking
(Not tracked)
People
(Reporter: standard8, Unassigned)
References
(Blocks 1 open bug)
Details
I've attempted to use the bash-completion.sh script, but it is really too slow on my machine.
I'm on a Mid 2015 MacBook Pro running 10.13.6 with an ssd drive.
When I'm trying to autocomplete, it takes roughly just under a second to complete ./mach mochitest, then probably just above a second to autocomplete anything after that (I'm doing rough estimates here).
The real pain is when I'm attempting to do something like:
./mach mochitest browser/components/urlbar/
That's three seconds for the sub-directories (and worse if there's more). As nice as it is having autocomplete, delaying the directory completion makes it just slightly too painful for me to use it at the moment.
Running ./mach mach-completion takes about 0.7 - 0.8 seconds, so I suspect that's probably where most of this delay is coming from.
|
||
Comment 1•5 years ago
|
||
Yes, this needs to be fixed. It's calling into a mach command to get the completion targets which incurs both python and mach startup costs. We should probably figure out some way to cache the completion targets to disk to avoid this.
Description
•