1521484 - calling 'get next: 10 / 20 / 50 pushes' loads them but doesn't add "fromchange <revision>" to 'Active Filters' bar anymore

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Calling 'get next: 10 / 20 / 50 pushes' loads them but doesn't add "fromchange <revision>" to 'Active Filters' bar anymore.

Steps to reproduce:

1. Load a tree, e.g. https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel%2Cretry&group_state=expanded
2. Go to the bottom and let it load 10 more pushes.
   Actual result:
   10 more pushes loaded but bar "Active Filters:" has no rule "fromchange". URL contains fromchange.
3. Reload the page.
   Actual result:
   "Active Filters:" contains "fromchange".

Comment 1

[Ed Morley [:emorley]]

I can reproduce on production.

Bisecting locally, it seems to have started as of:
https://github.com/mozilla/treeherder/pull/4353

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4492

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/2d1c4adb7ca6164f5b4d0264ef3eddbbd377ceb6
Bug 1521484 - Fix fromchange showing in ActiveFiltersBar (#4492)

I forgot to add this and a few others to the list of filters
that should get inspected in the App.handleUrlChange.