Closed Bug 1521493 Opened 5 years ago Closed 5 years ago

Add fingerprinting and cryptomining tables to SafeBrowsing update list

Categories

(Toolkit :: Safe Browsing, defect, P1)

Product:
Toolkit
Component:
Safe Browsing
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox66 + fixed

People

(Reporter: dimi, Assigned: dimi)

References

Details

Attachments

(1 file)

Bug 1521493 - Add fingerprinting and cryptomining tables to SafeBrowsing update list. r=baku
47 bytes, text/x-phabricator-request
Details | Review

This is the final step to enable fingerprinting and cryptomining on nightly.

I tested the local build with the patch applied, fingerprinting/cryptoming features work after the fix in Bug 1515806 Comment 17

Blocks: 1513490
Priority: -- → P1

We can download the list from shavar server now, enable SafeBrowsing to download the list

The bug says in Nightly but your patch is enabling them unconditionally. Is that intentional?

Flags: needinfo?(dlee)

(In reply to :Ehsan Akhgari from comment #3)

The bug says in Nightly but your patch is enabling them unconditionally. Is that intentional?

Sorry, I should make the description more clear.
It is already enabled in Nightly because of the #ifdef here[1], but since the tables are not yet added to SafeBrowsing update list, there is no effect.

I'll change the bug summary and also add descriptions to the patch.

[1] https://searchfox.org/mozilla-central/rev/6c784c93cfbd5119ed07773a170b59fbce1377ea/modules/libpref/init/StaticPrefList.h#1822

Flags: needinfo?(dlee)
Summary: Enable fingerprinting and cryptomining on nightly by default → Add fingerprinting and cryptoming tables to SafeBrowsing update list

I will land this after code freeze for 66

Great, thanks!

Based on comment 4, I don't think the soft freeze criteria applies to this, FWIW.

Attachment #9038206 - Attachment description: Bug 1521493 - Enable fingerprinting and cryptomining on nightly by default. r?baku → Bug 1521493 - Add fingerprinting and cryptomining tables to SafeBrowsing update list. r=baku
Summary: Add fingerprinting and cryptoming tables to SafeBrowsing update list → Add fingerprinting and cryptomining tables to SafeBrowsing update list
Pushed by dlee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3f8aeb316a5c
Add fingerprinting and cryptomining tables to SafeBrowsing update list. r=baku

https://hg.mozilla.org/mozilla-central/rev/3f8aeb316a5c

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox66: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.