1521493 - Add fingerprinting and cryptomining tables to SafeBrowsing update list

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect, P1)

Description

[Dimi Lee [:dimi]]

This is the final step to enable fingerprinting and cryptomining on nightly.

Comment 1

[Dimi Lee [:dimi]]

I tested the local build with the patch applied, fingerprinting/cryptoming features work after the fix in Bug 1515806 Comment 17

Comment 2

[Dimi Lee [:dimi]]

Attachment: Bug 1521493 - Add fingerprinting and cryptomining tables to SafeBrowsing update list. r=baku

We can download the list from shavar server now, enable SafeBrowsing to download the list

Comment 3

[(no longer active)]

The bug says in Nightly but your patch is enabling them unconditionally. Is that intentional?

Comment 4

[Dimi Lee [:dimi]]

(In reply to :Ehsan Akhgari from comment #3)

The bug says in Nightly but your patch is enabling them unconditionally. Is that intentional?

Sorry, I should make the description more clear.
It is already enabled in Nightly because of the #ifdef here[1], but since the tables are not yet added to SafeBrowsing update list, there is no effect.

I'll change the bug summary and also add descriptions to the patch.

[1] https://searchfox.org/mozilla-central/rev/6c784c93cfbd5119ed07773a170b59fbce1377ea/modules/libpref/init/StaticPrefList.h#1822

Comment 5

[Dimi Lee [:dimi]]

I will land this after code freeze for 66

Comment 6

[(no longer active)]

Great, thanks!

Based on comment 4, I don't think the soft freeze criteria applies to this, FWIW.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f8aeb316a5c
Add fingerprinting and cryptomining tables to SafeBrowsing update list. r=baku

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3f8aeb316a5c