Canary client ID in aborted-session pings
Categories
(Toolkit :: Telemetry, enhancement, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: janerik, Assigned: janerik)
Details
Attachments
(1 file)
Looks like we still get a lot of pings with canary client IDs with reason "aborted-session".
Explanation on how this can happen:
- User disables Telemetry
- Telemetry still writes aborted-session pings every few minutes to disk as normal (main pings with reason "aborted-session")
- Firefox instance is killed/aborted, aborted-session ping remains
- User re-enables Telemetry
- On next start unsent aborted-session file is detected and send.
We should either avoid writing the aborted-session ping at all or clear it out when enabling Telemetry again.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
The aborted-sessions ping is written periodically, even when Telemetry
upload is enabled (and thus the profile has a canary client ID).
On later starts, if this file exists, it is read and send if upload is enabled
(which could have happened in the previous session or by changing prefs.js).
If we now detect that it contains the canary client ID we avoid sending it
and simply remove the file from disk.
|
|
Assignee | |
Comment 2•5 years ago
|
||
The attached patch will block aborted-session pings to go out with a canary client ID.
I still wonder if we should catch this before sending any ping.
|
||
Comment 3•5 years ago
|
||
bug 1490668 in other words?
|
|
Assignee | |
Comment 4•5 years ago
|
||
Yes.
Pushed by jrediger@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bd47fa49ab01 Don't send aborted-session with a canary client ID r=chutten
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Description
•