Closed Bug 1521685 Opened 2 years ago Closed 2 years ago

clang build warning: widget/windows/nsDataObj.cpp(864,11): warning: unused variable 'err' [-Wunused-variable]

Categories

(Core :: Widget: Win32, defect)

65 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox-esr60 --- unaffected
firefox64 --- unaffected
firefox65 --- wontfix
firefox66 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

(Keywords: regression)

Attachments

(1 file)

15:00.77 In file included from m:/fx64-dbg/widget/windows/Unified_cpp_widget_windows1.cpp:101:
15:00.81 m:/src/widget/windows/nsDataObj.cpp(864,11): warning: unused variable 'err' [-Wunused-variable]
15:00.83 DWORD err = ::GetLastError();
15:00.83 ^

nsDataObj::GetDib() calls GetLastError() API immediately after calling
GlobalAlloc() and just return E_FAIL in such case. So, we don't need to
call it.

Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/607394a48aca
Get rid of unused GetLastError() API call in nsDataObj::GetDib() r=aosmond
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
https://hg.mozilla.org/projects/cedar/rev/607394a48aca3721c9386d975fc2fce29bdcba59
Bug 1521685 - Get rid of unused GetLastError() API call in nsDataObj::GetDib() r=aosmond
You need to log in before you can comment on or make changes to this bug.