Closed
Bug 1521690
Opened 5 years ago
Closed 5 years ago
clang build warning: widget/windows/nsWindow.cpp(4951,7): warning: expression result unused; should this cast be to 'void'? [-Wunused-value]
Categories
(Core :: Widget: Win32, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
Details
Attachments
(1 file)
15:06.45 m:/src/widget/windows/nsWindow.cpp(4951,7): warning: expression result unused; should this cast be to 'void'? [-Wunused-value]
15:06.48 (void*)GetAccessible();
15:06.51 ^ ~
|
Assignee | |
Comment 1•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb17bf01e5517bbc9d67dc6f3b9b2211c63f34ab
|
|
Assignee | |
Comment 2•5 years ago
|
||
Casting non-void result to void* causes warning of clang. Additionally,
perhaps, we should use Unused << because of modern style.
|
|
Assignee | |
Comment 3•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=45f007adf8696f336c9a42068e3ca8bbd663b4a5
|
|
Assignee | |
Comment 4•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=400509ff5220d675ba62da9dec60a51307210fe9
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/8a968b7beaba Use `Unused <<` instead of `(void*)` in nsWindow.cpp r=aklotz,jmathies
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in
before you can comment on or make changes to this bug.
Description
•