1521694 - clang build warning: widget/windows/nsWindow.cpp(4688,13): warning: enumeration value 'nsSizeMode_Invalid' not handled in switch [-Wswitch]

Status: RESOLVED FIXED

(Core :: Widget: Win32, enhancement)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

0:17.89 In file included from m:/fx64-dbg/widget/windows/Unified_cpp_widget_windows2.cpp:110:
0:17.89 m:/src/widget/windows/nsWindow.cpp(4688,13): warning: enumeration value 'nsSizeMode_Invalid' not handled in switch [-Wswitch
0:17.89 switch (sizeMode) {
0:17.89 ^

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=86f651b226c59a95797c3a5874daa52ef84996f7

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1521694 - Make DisplaySystemMenu() handle all nsSizeMode value

DisplaySystemMenu() does not handle nsSizeMode_Invalid that causes warning of
clang. This patch makes it treat nsSizeMode_Invalid. When it receives the
value, it will call NS_ASSERTION() to be detectable on debug builds during
automated tests.

Additionally, this adds default case into the switch statement with
MOZ_ASSERT_UNREACHABLE(). Then, when somebody adds new nsSizeMode, they
can detect it with crash in debug build if they forget to change this method.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3883a443b7f8
Make DisplaySystemMenu() handle all nsSizeMode value r=jmathies

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/3883a443b7f8