Open Bug 1521714 Opened 4 years ago Updated 2 months ago

Remove unneeded connections map from devtools/server/startup/frame.js

Categories

(DevTools :: General, enhancement, P3)

enhancement

Tracking

(Not tracked)

People

(Reporter: jdescottes, Unassigned)

References

Details

Follow up to Bug 1521052.

The frame script injected in content processes to spawn a DebuggerServer can only ever handle one connection. However it misleadingly stores connections in a map, suggesting it might handle more than that.

https://searchfox.org/mozilla-central/rev/330daedbeac2bba296d663668e0e0cf248bc6823/devtools/server/startup/frame.js#33

We should just store the connection and its prefix.

Comment from Alex in the blocking bug suggests we might be able to not even store the prefix and simply rely on childID.

It looks like a bad comprehension of things from this changeset.
We only have to check for childID when we receive debug:disconnect, but we don't need a Map.

Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.