Remove remainder of about:searchreset

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P1
normal
RESOLVED FIXED
3 months ago
17 days ago

People

(Reporter: Gijs, Assigned: daleharvey)

Tracking

(Blocks 1 bug)

Trunk
Firefox 67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 wontfix, firefox67 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Comment 1

3 months ago

Also:

https://searchfox.org/mozilla-central/rev/330daedbeac2bba296d663668e0e0cf248bc6823/modules/libpref/init/all.js#2677

I believe the fluent migration will be removed by flod once 65 hits release or something. Flod?

Flags: needinfo?(francesco.lodolo)
(Assignee)

Comment 2

3 months ago

Cheers for pointing those out, ill clean them up

Assignee: nobody → dharvey

I believe the fluent migration will be removed by flod once 65 hits release or something. Flod?

Yes, and there's already a patch in bug 1521695, likely to land later today.

Flags: needinfo?(francesco.lodolo)

Updated

3 months ago
Priority: -- → P1
(Assignee)

Comment 5

3 months ago

Doing the nsSearchService patch seperately so we can land it on cedar then uplift and avoid conflicts

(Reporter)

Comment 7

a month ago

Did this get lost?

Flags: needinfo?(dharvey)
(Assignee)

Comment 8

a month ago

Sorry yeh was avoiding landing a conflict then forgot, rebased, squashed the commits and pushed to try

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9a8662a03439e35c7bf32a45d60717edce577327

Flags: needinfo?(dharvey)
Attachment #9038958 - Attachment is obsolete: true

Comment 9

a month ago
Pushed by dharvey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7444d00f6a08
Remove remaining about:searchreset references. r=Gijs

Comment 10

a month ago
bugherder
Status: NEW → RESOLVED
Last Resolved: a month ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67

Double checking that this is OK to wontfix in 66. Please let me know if it's something you think needs to be addressed during 66 release.

Flags: needinfo?(dharvey)
(Assignee)

Comment 12

a month ago

Yup this is purely cleanup nothing user facing, I think would only think about uplifting if there was a bunch of uplifts planned and wanted to avoid conflicts / branch patches but I dont think thats the case

Flags: needinfo?(dharvey)

Comment 13

a month ago

FYI ...

  • _isWhiteListed doesn't seem to be used anymore either (see [1] and [2])
  • the pref browser.search.reset.whitelist looks unused as well and can be removed from all.js (see [3])
  • ideally browser.search.reset.status could be reset in a migration block in BrowserGlue.jsm because it was set there for if (currentUIVersion < 59)
  • browser.search.reset.enabled is still used in 2 xpcshell tests (see [4]) but I don't know if that actually does anything anymore. If not, then that pref could be removed from firefox.js and all.js (see [4])

Thanks

[1] https://hg.mozilla.org/mozilla-central/file/7444d00f6a08/toolkit/components/search/SearchService.jsm#l2302
[2] https://dxr.mozilla.org/mozilla-beta/search?q=_isWhiteListed
[3] https://dxr.mozilla.org/mozilla-central/search?q=reset.enabled
[4] https://dxr.mozilla.org/mozilla-central/source/modules/libpref/init/all.js#5798

Flags: needinfo?(dharvey)
Blocks: 1542713

(In reply to Anna from comment #13)

FYI ...

Thank you for pointing those out. I just filed bug 1542713 to handle those.

Flags: needinfo?(dharvey)
You need to log in before you can comment on or make changes to this bug.