1521743 - Source and type label for CardGrid component

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Andrei Oprea [:andreio]]

Attachment: Screenshot 2019-01-22 at 12.53.01.png

The bottom label / text [see attachment] of the card does not match the current spec.

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Screenshot 2019-01-22 at 12.53.31.png

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4717

Comment 3

[Scott [:thecount] Downe]

To test:

1. Any layout with a hero unit would do, example: {"enabled":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all"}
2. Load a new tab and ensure hero cards don't say "TODO: SOURCE" but instead say the source.

Comment 4

[Ed Lee :Mardak]

This landed in https://github.com/mozilla/activity-stream/commit/672e9c01abfd182e3a67af37dedcaa3dd2708beb but did not have the bug number in the commit message.

"using domain for article sources (#4717)"

Exported in bug 1522752 https://hg.mozilla.org/mozilla-central/rev/9d660bf33923

Comment 5

[Brahmini Nagabandi]

Attachment: QA Results : bug - 1521743.png

QA Results:

Tested on :

FF Nightly version : 67.0a1 (2019-01-31)
OS : Mac and Windows 10 Pro

Results attached QA Results : bug - 1521743.png

Seeing the actual source.

Closing as verified.