Closed Bug 1521780 Opened 7 months ago Closed 7 months ago

Rename memory.drop and table.drop

Categories

(Core :: Javascript: WebAssembly, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: lth, Assigned: lth)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-needed)

Attachments

(1 file)

Memory.drop -> data.drop, and table.drop -> elem.drop, per agreement in https://github.com/WebAssembly/bulk-memory-operations/issues/23, see also https://github.com/WebAssembly/bulk-memory-operations/pull/46.

I won't land this until my PR against the spec has been accepted, but might as well review...

Attachment #9038255 - Flags: review?(jseward)
Comment on attachment 9038255 [details] [diff] [review]
bug1521780-rename-drops.patch

Review of attachment 9038255 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine.
Attachment #9038255 - Flags: review?(jseward) → review+
Pushed by lhansen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b9d92a7c779
Rename memory.drop and table.drop.  r=jseward
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
See Also: → 1523081

Adding dev-doc-needed just to make sure we get the names right if/when we cover this one MDN anywhere.

Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.