Remove our columnpicker.svg after bug 1022039 adds it to toolkit

RESOLVED FIXED

Status

enhancement
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 months ago

Bug uses now our columnpicker.svg. With this, we need no more to implement it for our own and can remove it from our tree.

(Assignee)

Comment 1

3 months ago

You will see no difference as m-c uses our columnpicker.svg. They only removed a empty line after the license boilerplate.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9038285 - Flags: review?(jorgk)

Comment 2

3 months ago

OK, M-C also added

+  -moz-context-properties: fill;
+  fill: currentColor;

Do we have those lines and can remove them somewhere?

(Assignee)

Comment 3

3 months ago

We have them here for example: https://searchfox.org/comm-central/source/mail/themes/linux/mail/messenger.css#515

We can't remove theme because we need them for the other icons in the treecols.

Comment 4

3 months ago
Comment on attachment 9038285 [details] [diff] [review]
1521847-remove-columnpicker.svg.patch

OK then. Did the M-C bug acknowledge where they had the icon from.
Attachment #9038285 - Flags: review?(jorgk) → review+
(Assignee)

Comment 5

3 months ago

In the bug is a link from where it can be found in our repository.

Keywords: checkin-needed

Comment 6

3 months ago

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/d12f961a202e
Remove C-C's columnpicker.svg after bug 1022039 adds it to M-C's toolkit. r=jorgk

Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.