Closed
Bug 1521886
Opened 7 years ago
Closed 7 years ago
horizontal rules at top of ds-list and above individual items should be 1px thick, not 2px, and correct color
Categories
(Firefox :: New Tab Page, defect, P1)
Firefox
New Tab Page
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: dmosedale, Assigned: dmosedale)
References
Details
(Keywords: github-merged)
User Story
horizontal rules at top of ds-list and above individual items should be 1px thick, not 2px, and correct color
How to test:
* go to about:config
* search for stream.config
* set that preference to {"enabled":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all"}
* open a new tab
Inspect the long horizontal rule at the top of the one of the list. Also inspect the shorter line (which is implemented as a border) above one of the .ds-items. Both should be 1 pixel thick, and the color of the lines should be #D7D7DB (which is the same as rgb(215, 215, 219)).
Attachments
(2 files)
QA Result : Bug -1521886.png
No description provided.
|
Assignee | |
Updated•7 years ago
|
User Story: (updated)
Summary: horizontal rules at top of ds-list and above individual items should be 1px thick, not 2px → horizontal rules at top of ds-list and above individual items should be 1px thick, not 2px, and correct color
|
||
Updated•7 years ago
|
Iteration: --- → 66.4 - Jan 21 - 27
Priority: -- → P1
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → dmose
|
||
Comment 1•7 years ago
|
||
|
|
Assignee | |
Updated•7 years ago
|
User Story: (updated)
|
||
Comment 2•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/863c6b5108e78692781ed4174aedd199069d96e1
Bug 1521886 - update thicknesss/color of ds-list horizontal rules (#4706)
|
|
Assignee | |
Updated•7 years ago
|
Keywords: github-merged
|
||
Comment 3•7 years ago
|
||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
|
|
||
Comment 4•7 years ago
|
||
QA Results:
Tested on :
FF Nightly version : 66.0a1 (2019-01-25)
OS : Mac and Windows 10 Pro
Results attached QA Result : Bug -1521886.png
Looks good to me, closing as verified.
|
|
||
Updated•7 years ago
|
Status: RESOLVED → VERIFIED
|
||
Updated•7 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•