(In reply to Micah Tigley [:mtigley] from comment #9)
Thank you for the patch. I tested this out and it works great! I left some comments on Phabricator.
For tests, we don't need to worry about them if we're concerned about the highlighter info-bar's max-width styles. I think this patch alone is good enough.
Thank you Micah,
I understand what you said in Phabricator regarding following the suggestion made by Victoria.
For Victoria's information, I summarize what I said in Phabricator.
Since I set the
max-width on the overall infobar, I found that
500px was too short for pretty common use cases like one autogenerated id and 3-4 classes. In thise case we could hardly see all the selectors.
For information, I use autogenerated id for accessibility in components and I need to check easily the match between
aria-labelledby attribute for example. I take my use case as an example but I think it is pretty common. Regarding classes, 3-4 classes or more with BEM styles or the new (or somehow renewal) trend of utility classes are not uncommon too. We could do it through the DOM but it is a matter of convenience, like the infobar.
Though, I suggested we could put a
500px max width on each block (
Let me know what you think.