Closed Bug 1521920 Opened 10 months ago Closed 10 months ago

Removing conditional compilation for debug_renderer

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: bholley, Assigned: bholley)

Details

Attachments

(1 file)

There's a lot of code to allow compiling out the support code for debug rendering. This adds clutter, and is also time-consuming to maintain, because it's easy to accidentally break the not(debug_renderer) configuration and get bounced by CI.

The argument for keeping it would be if we wanted to compile these out on release. I don't think we do, because it's not a lot of codesize, and is useful for diagnosing issues in the wild. We're actually shipping it already in release (since WebRender is shipped but preffed off), so if we're willing to take that codesize hit I don't see us changing our minds once the debug displays become more useful for more people.

Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9e84fa9a6b9c
Remove conditional compilation around debug_renderer. r=emilio
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.