Closed
Bug 1521987
Opened 5 years ago
Closed 5 years ago
Add missing doorhanger staging tests
Categories
(Toolkit :: Application Update, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
References
Details
Attachments
(2 files)
|
3.93 KB,
patch
|
molly
:
review+
|
Details | Diff | Splinter Review |
|
1.93 KB,
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
I'm checking current test coverage and found a couple of missing doorhanger tests
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Comment on attachment 9038395 [details] [diff] [review] patch rev1 Passed locally and I'll make sure this passes try before landing.
Attachment #9038395 -
Flags: review?(mhowell)
|
||
Updated•5 years ago
|
Attachment #9038395 -
Flags: review?(mhowell) → review+
Pushed by rstrong@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/48afe4849336 Add missing doorhanger staging tests. r=mhowell
Pushed by rstrong@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/844767deacdb followup to prevent these staging tests from running on asan. r=me CLOSED TREE
|
|
Assignee | |
Comment 5•5 years ago
|
||
I forgot to disable these tests on asan since staging leaks currently.
Attachment #9038466 -
Flags: review+
|
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/48afe4849336
https://hg.mozilla.org/mozilla-central/rev/844767deacdb
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•