Closed Bug 1521987 Opened 2 years ago Closed 2 years ago

Add missing doorhanger staging tests

Categories

(Toolkit :: Application Update, enhancement)

59 Branch
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

Attachments

(2 files)

I'm checking current test coverage and found a couple of missing doorhanger tests

Comment on attachment 9038395 [details] [diff] [review]
patch rev1

Passed locally and I'll make sure this passes try before landing.
Attachment #9038395 - Flags: review?(mhowell)
Attachment #9038395 - Flags: review?(mhowell) → review+
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/48afe4849336
Add missing doorhanger staging tests. r=mhowell
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/844767deacdb
followup to prevent these staging tests from running on asan. r=me CLOSED TREE
Attached patch patch followupSplinter Review

I forgot to disable these tests on asan since staging leaks currently.

Attachment #9038466 - Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.