Closed Bug 1522009 Opened 2 years ago Closed 2 years ago

Our web-platform-tests "meta" folder has some .ini files with just the test name but no annotations

Categories

(Testing :: web-platform-tests, enhancement)

enhancement
Not set
normal

Tracking

(firefox66 fixed)

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I noticed that we've got some .ini WPT-test-annotation files that don't actually have any annotations -- they just have 1 line (the name of the test) but no "expected: FAIL" or anything like that.

Here's the command I wrote to find these files:

wc -l `find testing/web-platform/meta -name "*.ini"` | \
   grep " 1 " | grep -v "__dir__"

Right now that^^ command turns up 55 results. For example, these two:
https://searchfox.org/mozilla-central/source/testing/web-platform/meta/css/vendor-imports/mozilla/mozilla-central-reftests/multicol3/multicol-height-002.xht.ini
https://searchfox.org/mozilla-central/source/testing/web-platform/meta/css/vendor-imports/mozilla/mozilla-central-reftests/background/background-attachment-fixed-inside-transform-1.html.ini

jgraham, do these files serve any purpose, or can we remove them?

Flags: needinfo?(james)

(Note: I'm loosely tying this to bug 1520946 since these .ini files show up as some of the "false matches" in the searchfox query for possible-tests-to-look-into over on that bug.)

Yeah, that's either the automatic update code doing something funky or a mistake from a human. In either case these files are useless and can be removed.

Flags: needinfo?(james)

Note: a few of the files that are turned up by my command in comment 0 are actually worth keeping, because their one-liner is a "prefs: ..." declaration, rather than the filename.

E.g. this one:
https://searchfox.org/mozilla-central/source/testing/web-platform/meta/workers/WorkerPerformanceNow.html.ini

I filtered those out when generating the patch here by doing "grep -v" for "prefs:" on my list of candidate files, before doing a hg rm. And I went through the raw diff of my patch to manually sanity-check that all of the removed one-liners just had the filename as the removed line.

Assignee: nobody → dholbert
Status: NEW → ASSIGNED

Core: General probably isn't a good place for this so I moved it to the wpt component.

Component: General → web-platform-tests
Product: Core → Testing
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/autoland/rev/4c814c2de16d
Remove WPT .ini annotation files that don't actually contain any annotations. r=jgraham
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.