Closed Bug 1522017 Opened 10 months ago Closed 10 months ago

Explicitly opt in to the the tile cache when pushing a stacking context

Categories

(Core :: Graphics: WebRender, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(4 files)

WebRender currently uses a hacky guess [1] to identify the picture corresponding to the top-level content document, in order to enable the tile cache. We want to make this explicit instead, both to be robust against the hack breaking, and to allow us to enable picture caching for scenes displayed via wrench.

The stacking context API is pretty unwieldy, and I'm reluctant to add yet another boolean parameter to the existing mess. So I'm doing a bit of pre-work to pass optional params via a struct, which should make it straightforward to pass the information we need to WR display list construction.

[1] https://searchfox.org/mozilla-central/rev/6c784c93cfbd5119ed07773a170b59fbce1377ea/gfx/wr/webrender/src/display_list_flattener.rs#1228

Priority: -- → P3

Depends on D17434

Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/145d739c4139
Introduce StackingContextParams to avoid death by a thousand argument. r=emilio
https://hg.mozilla.org/integration/autoland/rev/7ba7f98526f4
Make picture caching explicit. r=gw
https://hg.mozilla.org/integration/autoland/rev/44febac9160b
Clip picture caching debug display to avoid overflowing the browser chrome. r=gw
https://hg.mozilla.org/integration/autoland/rev/21462a8e2018
Don't push an extra stacking context for iframes, and eliminate solid rect at pipeline roots. r=gw
You need to log in before you can comment on or make changes to this bug.