1522017 - Explicitly opt in to the the tile cache when pushing a stacking context

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Bobby Holley (:bholley)]

WebRender currently uses a hacky guess [1] to identify the picture corresponding to the top-level content document, in order to enable the tile cache. We want to make this explicit instead, both to be robust against the hack breaking, and to allow us to enable picture caching for scenes displayed via wrench.

The stacking context API is pretty unwieldy, and I'm reluctant to add yet another boolean parameter to the existing mess. So I'm doing a bit of pre-work to pass optional params via a struct, which should make it straightforward to pass the information we need to WR display list construction.

[1] https://searchfox.org/mozilla-central/rev/6c784c93cfbd5119ed07773a170b59fbce1377ea/gfx/wr/webrender/src/display_list_flattener.rs#1228

Comment 1

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d3ff4f844ff1ebb9e20965c9a9df496b069180d

Comment 2

[Bobby Holley (:bholley)]

Attachment: Bug 1522017 - Introduce StackingContextParams to avoid death by a thousand argument.

Comment 3

[Bobby Holley (:bholley)]

Attachment: Bug 1522017 - Make picture caching explicit.

Depends on D17434

Comment 4

[Bobby Holley (:bholley)]

Attachment: Bug 1522017 - Clip picture caching debug display to avoid overflowing the browser chrome.

Depends on D17435

Comment 5

[Bobby Holley (:bholley)]

Attachment: Bug 1522017 - Don't push an extra stacking context for iframes, and eliminate solid rect at pipeline roots.

Depends on D17436

Comment 6

[Bobby Holley (:bholley)]

(In reply to Bobby Holley (:bholley) from comment #1)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d3ff4f844ff1ebb9e20965c9a9df496b069180d

Wrench was busted, here's a green run:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3c6b7ac4b89ab2db2301824f0a2dae6e5f446002

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/145d739c4139
Introduce StackingContextParams to avoid death by a thousand argument. r=emilio
https://hg.mozilla.org/integration/autoland/rev/7ba7f98526f4
Make picture caching explicit. r=gw
https://hg.mozilla.org/integration/autoland/rev/44febac9160b
Clip picture caching debug display to avoid overflowing the browser chrome. r=gw
https://hg.mozilla.org/integration/autoland/rev/21462a8e2018
Don't push an extra stacking context for iframes, and eliminate solid rect at pipeline roots. r=gw

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/145d739c4139
https://hg.mozilla.org/mozilla-central/rev/7ba7f98526f4
https://hg.mozilla.org/mozilla-central/rev/44febac9160b
https://hg.mozilla.org/mozilla-central/rev/21462a8e2018