1522044 - Release of pip 19.0 breaks the docker build

Status: RESOLVED WORKSFORME

(Webtools Graveyard :: Pontoon, defect)

Description

[exile]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) snap Chromium/71.0.3578.98 Chrome/71.0.3578.98 Safari/537.36

Steps to reproduce:

Try to build docker image of pontoon via make build

Actual results:

As pip is always upgraded to the latest and greatest the build started to fail as of pip 19.0 release. (webapp)

Requirement already satisfied: setuptools in /usr/local/lib/python2.7/site-packages (from python-levenshtein==0.12.0->-r requirements.txt (line 95)) (36.4.0)
Exception:
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/site-packages/pip/_internal/cli/base_command.py", line 176, in main
    status = self.run(options, args)
  File "/usr/local/lib/python2.7/site-packages/pip/_internal/commands/install.py", line 346, in run
    session=session, autobuilding=True
  File "/usr/local/lib/python2.7/site-packages/pip/_internal/wheel.py", line 848, in build
    assert building_is_possible
AssertionError
ERROR: Service 'webapp' failed to build: The command '/bin/sh -c pip install -U 'pip>=8' &&     pip install --no-cache-dir --require-hashes -r requirements-dev.txt &&     pip install --no-cache-dir --require-hashes -r requirements-test.txt' returned a non-zero code: 2

Expected results:

Build should pass, Pontoon build should not automatically start to consume the latest major release of dependencies. Use pip 18.1 as a workaround

In docker/Dockerfile change the pip upgrade version to "pip==18.1"

Or debug further why the build fails. PIP 19 lists deprecation of Python 2 as of 1st of January 2020.

Comment 1

[Axel Hecht [:Pike]]

Confirming.

The culprit is https://github.com/pypa/pip/blob/085e7403b2f405bcb7e475b7bcc40a4659a833a4/src/pip/_internal/wheel.py#L843-L848,

    # TODO: This check fails if --no-cache-dir is set. And yet we
    #       might be able to build into the ephemeral cache, surely?

and we pass --no-cache-dir to pip.

Comment 2

[Jarek Śmiejczak [:jotes]]

:Pike, :exile
It looks like PIP 19.1 fixed this issue (related bug: https://github.com/pypa/pip/issues/6158).

Comment 3

[Matjaz Horvat [:mathjazz]]

(In reply to Jarek Śmiejczak [:jotes] from comment #2)

It looks like PIP 19.1 fixed this issue (related bug: https://github.com/pypa/pip/issues/6158).

Which means this bug just fixed itself?

Comment 4

[Axel Hecht [:Pike]]

I'd say so. Resolving, as we probably don't need to do tricky things to avoid just version 19.0.