Closed Bug 1522067 Opened 8 months ago Closed 8 months ago

Add additional info about commit messages & blocking reviews

Categories

(DevTools :: General, enhancement, P3)

enhancement

Tracking

(firefox67 fixed)

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: ogasidlo, Assigned: championshuttler)

Details

(Keywords: good-first-bug, Whiteboard: dt-docs)

Attachments

(1 file)

devtools/docs/contributing/making-prs.md - Line 7

Change:


First, commit your changes. For example:

hg add /path/to/file/changed
hg commit -m "Bug 1234567 - Implement feature XYZ."

to


First, commit your changes. For example:

hg add /path/to/file/changed
hg commit -m "Bug 1234567 - Implement feature XYZ. r=name,name2!"

The commit message explained in detail:

  • Bug 1234567 - The number of the bug in bugzilla.
  • - Implement feature XYZ. - The commit message.
  • r=name - The short form to request a review.
  • ,name2! - You can have more than one reviewer. The ! makes the review a blocking review (Patch can not land without accepted review). You will also need to add it to the name in the popup after you ran arc diff.

Please note your first commit message will be also the title of your patch in Phabricator. (Don't worry, if something goes wrong. You can still change things in the UI later).


I think, r?name will be more suitable for commits instead of r=name

to


First, commit your changes. For example:

hg add /path/to/file/changed
hg commit -m "Bug 1234567 - Implement feature XYZ. r=name, name2!"
Flags: needinfo?(ogasidlo)

Phabricator is able to parse both r?name as well as r=name.

The recommendation for devtools is r=name.

Flags: needinfo?(ogasidlo)

Add additional info about commit messages and blocking reviews.

Attachment #9040995 - Attachment description: Bug 1522067 - Add additional info about commit messages & blocking reviews, r=ola → Bug 1522067 - Add additional info about commit messages & blocking reviews. r=ola
Assignee: nobody → shivams2799
Status: NEW → ASSIGNED
Pushed by ogasidlo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3a1f671e9526
Add additional info about commit messages & blocking reviews. r=Ola
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.