1522075 - Some minor BaselineCompiler refactorings

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P1)

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1522075 part 1 - Simplify some module-related code. r?jonco!

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1522075 part 2 - Move prepareVMCall calls into lambdas because prepareVMCall and callVM have to be balanced. r?djvj!

This fixes some assertion failures when generating the interpreter.

Depends on D17365

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1522075 part 3 - Add MacroAssembler::guardedCallPreBarrierAnyZone for use in trampolines. r?djvj!

When generating the interpreter, we assert in guardedCallPreBarrier because
JitContext::realm is nullptr. This adds guardedCallPreBarrierAnyZone for that
use case: it loads cx->zone dynamically instead of baking it in.

Depends on D17366

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1522075 part 4 - Some JitContext assertions and clean up. r?luke!

When we generate the Baseline interpreter and other trampolines, JitContext's
realm is nullptr. We now assert it's non-null in JitContext::realm().

I also replaced JitContext::zone with JitContext::isCompilingWasm_.

Depends on D17367

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2e14bfdfb00
part 1 - Simplify some module-related code. r=jonco
https://hg.mozilla.org/integration/autoland/rev/59e188c6e835
part 2 - Move prepareVMCall calls into lambdas because prepareVMCall and callVM have to be balanced. r=djvj
https://hg.mozilla.org/integration/autoland/rev/eff43158adb8
part 3 - Add MacroAssembler::guardedCallPreBarrierAnyZone for use in trampolines. r=djvj
https://hg.mozilla.org/integration/autoland/rev/ced24b663e65
part 4 - Some JitContext assertions and clean up. r=luke

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a2e14bfdfb00
https://hg.mozilla.org/mozilla-central/rev/59e188c6e835
https://hg.mozilla.org/mozilla-central/rev/eff43158adb8
https://hg.mozilla.org/mozilla-central/rev/ced24b663e65