Some minor BaselineCompiler refactorings
Categories
(Core :: JavaScript Engine: JIT, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(4 files)
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
This fixes some assertion failures when generating the interpreter.
Depends on D17365
|
|
Assignee | |
Comment 3•5 years ago
|
||
When generating the interpreter, we assert in guardedCallPreBarrier because
JitContext::realm is nullptr. This adds guardedCallPreBarrierAnyZone for that
use case: it loads cx->zone dynamically instead of baking it in.
Depends on D17366
|
|
Assignee | |
Comment 4•5 years ago
|
||
When we generate the Baseline interpreter and other trampolines, JitContext's
realm is nullptr. We now assert it's non-null in JitContext::realm().
I also replaced JitContext::zone with JitContext::isCompilingWasm_.
Depends on D17367
|
|
Assignee | |
Updated•5 years ago
|
|
||
Updated•5 years ago
|
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a2e14bfdfb00 part 1 - Simplify some module-related code. r=jonco https://hg.mozilla.org/integration/autoland/rev/59e188c6e835 part 2 - Move prepareVMCall calls into lambdas because prepareVMCall and callVM have to be balanced. r=djvj https://hg.mozilla.org/integration/autoland/rev/eff43158adb8 part 3 - Add MacroAssembler::guardedCallPreBarrierAnyZone for use in trampolines. r=djvj https://hg.mozilla.org/integration/autoland/rev/ced24b663e65 part 4 - Some JitContext assertions and clean up. r=luke
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a2e14bfdfb00
https://hg.mozilla.org/mozilla-central/rev/59e188c6e835
https://hg.mozilla.org/mozilla-central/rev/eff43158adb8
https://hg.mozilla.org/mozilla-central/rev/ced24b663e65
Description
•