Closed Bug 1522138 Opened Last year Closed Last year

Update Debugger Frontend v120

Categories

(DevTools :: Debugger, enhancement, P2)

enhancement

Tracking

(firefox66 fixed)

RESOLVED FIXED
Firefox 66
Tracking Status
firefox66 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

Details

Attachments

(1 file)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=34a2d198f09c2fda60591e8712699b4c59bb58ea

posting this now so that we can continue keeping the releases going even if we're not going to land them yet...

Attached patch 120-1.patchSplinter Review
Assignee: nobody → jlaster
Attachment #9038912 - Flags: review?(dwalsh)
No longer depends on: 1520957, 1518613
Comment on attachment 9038912 [details] [diff] [review]
120-1.patch

- Arrows look good
- Refresh looks good
- Memoizing working 
- Log points working
Attachment #9038912 - Flags: review?(dwalsh) → review+
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d05ea5ad7945
[release 120] [Breakpoint] fix selectBreakpoint (#7756). r=dwalsh
https://hg.mozilla.org/integration/mozilla-inbound/rev/10b38250b65e
[release 120] put log points behind a flag (#7761). r=dwalsh
https://hg.mozilla.org/integration/mozilla-inbound/rev/38d9045b04e6
[release 120] [Preview] Ensure correct event listening (#7778). r=dwalsh
https://hg.mozilla.org/integration/mozilla-inbound/rev/c4c105118de1
[release 120] [performance] Memoize breakpoints and URL parsing (#7774). r=dwalsh
https://hg.mozilla.org/integration/mozilla-inbound/rev/c2913cb9cb20
[release 120] Show proper icon for watch expression refresh (#7791). r=dwalsh
https://hg.mozilla.org/integration/mozilla-inbound/rev/0e402395db6c
[release 120] Fix color of arrows in trees (#7790). r=dwalsh
https://hg.mozilla.org/integration/mozilla-inbound/rev/cfc7aa2486d4
[release 120] Update debugger frontend. r=dwalsh

I think it is worth it to land these 7 commits despite the soft freeze for a couple of reasons

  • Fix color of arrows in trees (#7790). r=dwalsh
  • Show proper icon for watch expression refresh (#7791). r=dwalsh
  • [performance] Memoize breakpoints and URL parsing (#7774). r=dwalsh
  • [Preview] Ensure correct event listening (#7778). r=dwalsh
  • put log points behind a flag (#7761). r=dwalsh
  • [Breakpoint] fix selectBreakpoint (#7756). r=dwalsh
  1. the fixes are each small (style, ui regresion)
  2. they all have a significant user impact
  3. they are relatively small risk

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=cfc7aa2486d4eb6c42ba2714027465364b8a0da1

Blocks: 1523386
Blocks: 1523528
Blocks: 1525492
No longer blocks: 1525492
You need to log in before you can comment on or make changes to this bug.