Closed Bug 1522144 Opened 7 months ago Closed 7 months ago

migration scripts break for auth reasons for esr and central bumping

Categories

(Release Engineering :: Release Automation: Other, enhancement)

enhancement
Not set

Tracking

(firefox-esr60 fixed, firefox66 fixed)

VERIFIED FIXED
Tracking Status
firefox-esr60 --- fixed
firefox66 --- fixed

People

(Reporter: mtabara, Assigned: mtabara)

References

Details

(Whiteboard: [releaseduty])

Attachments

(1 file)

While performing mergeduty last Monday on the 21st of January everything went super smoothly but the esr bump which had minor auth hiccups (there was no default push set in the .hgrc and instead it's trying to query via https). If I recall correctly, we always have this problem for bumping central too. We've tracked this historically in this trello card.

While for merges (beta to release and central to beta) we don't have this problem, we do encounter if for the bumping behaviors (both esr and central). We have logic that automatically amends the .hg/hgrc to append the ffxbld user in the ssh counterpart section. We just need to turn that on.

This adds the missing ssh-amending step in the default actions of the both behaviors and slightly amends the function. This is needed as without it, the script would break here as the self.query_push_dirs() in this case normally returns (None, ...). This is happening because for merging configs we have both from_repo_url and to_repo_url set while for bumping counterpart we only have the latter, hence at runtime we end up with a None value there.

This fixes both bumping central and bumping esr runs.

I've tested on the mergeduty instance for both behaviors with the dry runs.

Attachment #9038553 - Flags: review?(mozilla)

Note to self: if Tom approves this, leftover is to:

  • land to inbound
  • let Sherrifs merge this to central
  • re-download the mozharness archive from this step in preparation for upcoming 26th Monday
  • let Johan know about this fix in preparation for Monday should I don't have enough time to do it by EOW
Whiteboard: [releaseduty]
Attachment #9038553 - Flags: review?(mozilla) → review+
Pushed by mtabara@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f6659c725cba
fix auth issues in bumping behaviors of mergeduty. r=tomprince a=release
Comment on attachment 9038553 [details] [diff] [review]
[in-tree] fix auth issues in bumping behaviors of mergeduty

https://hg.mozilla.org/integration/mozilla-inbound/rev/f6659c725cba
Attachment #9038553 - Flags: checked-in+

(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #2)

I'll let Sherrifs close the bug when they merge this to central.
After that leftovers are:

  • re-download the mozharness archive from this step in preparation for upcoming 26th Monday
  • let Johan know about this fix in preparation for Monday should I don't have enough time to do it by EOW
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED

(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #5)

(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #2)

I'll let Sherrifs close the bug when they merge this to central.
After that leftovers are:

  • re-download the mozharness archive from this step in preparation for upcoming 26th Monday
  • let Johan know about this fix in preparation for Monday should I don't have enough time to do it by EOW

Done. Re-downloaded the latest mozharess from central with the fix.
On Monday, the bumping script should just work.

Status: RESOLVED → VERIFIED

Note to self: Johan said he did encounter an issue when bumping central last week. More details here. I'll keep this in mind for the next mergeduty to see if it was intermittent or not. I might've messed up things with my dry-runs.

You need to log in before you can comment on or make changes to this bug.