Closed Bug 1522153 Opened 5 years ago Closed 5 years ago

PromptDelegate.onChoicePrompt passing a null for Choice[] choices parameter

Categories

(GeckoView :: General, enhancement, P1)

Unspecified
All
enhancement

Tracking

(firefox-esr60 wontfix, firefox65 wontfix, firefox66 wontfix, firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox-esr60 --- wontfix
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- fixed

People

(Reporter: amejia, Assigned: droeh)

References

Details

Attachments

(1 file)

In some cases we're getting pass a null value for the Choice[] choices parameter, from PromptDelegate.onChoicePrompt. Android Component bug.

Summary: PromptDelegate.onChoicePrompt passing a null Choice[] choices → PromptDelegate.onChoicePrompt passing a null for Choice[] choices parameter

Yeah, this looks like we're just passing null rather than an empty list, I'll put up a patch shortly.

Dylan will take a look. We probably want to pass a zero-length Choice[] array.

Assignee: nobody → droeh
Priority: -- → P1
Pushed by droeh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aefb791099f1
Pass an empty list rather than null to onChoicePrompt when no choices are present. r=snorp
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: